Share cohost code action tests with C# extension tests#12354
Merged
davidwengier merged 6 commits intodotnet:mainfrom Oct 21, 2025
Merged
Share cohost code action tests with C# extension tests#12354davidwengier merged 6 commits intodotnet:mainfrom
davidwengier merged 6 commits intodotnet:mainfrom
Conversation
Member
Author
|
Sorry for the last couple of commits. Will get the macbook out on monday and have a proper look :) |
Member
|
Are the product changes needed to share the tests? |
Member
Author
|
Not to share the code, no. I could skip the offending tests on mac/linux and follow up with fixes later. The feature might actually be broken on those platforms and we might not know, I was just too lazy last night to get out my mac and do proper work, I was guessing based on CI results from the couch :P |
davidwengier
force-pushed
the
ShareCohostCodeActionsTests
branch
from
d43796b to
ddca2e1
Compare
Member
Author
|
My bad, was an obvious bit of non-cross-platform-ness in the tests that I was completely blind to 🤦♂️ |
Member
Author
|
@dotnet/razor-tooling PTAL, there are a couple of new code actions that copilot can add for us, but if it can't run tests it probably won't do a great job :) |
DustinCampbell
approved these changes
Oct 21, 2025
This was referenced Oct 21, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot can't work on things it can't run tests for. This will allow it to work on code actions more effectively.