Merged
Conversation
chsienki
approved these changes
Oct 13, 2025
Member
chsienki
left a comment
chsienki
left a comment
There was a problem hiding this comment.
Just for my own learning: what do we use these for?
Member
Author
|
These are for classification of anything that doesn't support semantic tokens, which is to say Html, JavaScript and CSS. It's also the fallback for C# if there are things Roslyn doesn't give us tokens for (which I think there are). |
Member
Author
Member
Author
|
Manually tested with a very large .razor file, and cohsting/oop hit problems well before TextMate did. |
This was referenced Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component Governance doesn't like that we have an old, vulnerable, commit from the VS Code repo referenced, so I thought I'd bring our TextMate grammars up to date.
We could also just dismiss the alerts since none of this is executable, but why not have the latest (answer: because sometimes VS doesn't like us updating TextMate grammars). Will reach out to the editor team and see if there is something they want us to do to validate first.