Properly handle data for snippet completion items in cohosting#12303
Merged
davidwengier merged 2 commits intodotnet:mainfrom Oct 11, 2025
Merged
Properly handle data for snippet completion items in cohosting#12303davidwengier merged 2 commits intodotnet:mainfrom
davidwengier merged 2 commits intodotnet:mainfrom
Conversation
.../Microsoft.CodeAnalysis.Razor.CohostingShared/Completion/CohostDocumentCompletionEndpoint.cs
Outdated
Show resolved
Hide resolved
...oft.CodeAnalysis.Razor.CohostingShared/Completion/CohostDocumentCompletionResolveEndpoint.cs
Show resolved
Hide resolved
...oft.CodeAnalysis.Razor.CohostingShared/Completion/CohostDocumentCompletionResolveEndpoint.cs
Outdated
Show resolved
Hide resolved
...dio.LanguageServices.Razor.Test/Cohost/Shared/CohostDocumentCompletionResolveEndpointTest.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Oct 9, 2025
.../Microsoft.CodeAnalysis.Razor.CohostingShared/Completion/CohostDocumentCompletionEndpoint.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for the feedback, I think I've addressed it all |
DustinCampbell
approved these changes
Oct 10, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12286
Looks like in the original port of completion resolve to cohosting, snippets were just missed completely 🤷♂️