Allow publishing to fail, and just report that we're not synchronized#12301
Merged
davidwengier merged 2 commits intodotnet:mainfrom Oct 8, 2025
Merged
Allow publishing to fail, and just report that we're not synchronized#12301davidwengier merged 2 commits intodotnet:mainfrom
davidwengier merged 2 commits intodotnet:mainfrom
Conversation
davidwengier
commented
Oct 8, 2025
| public async Task PublishAsync(TextDocument document, SynchronizationResult synchronizationResult, string htmlText, CancellationToken cancellationToken) | ||
| public async Task<bool> PublishAsync(TextDocument document, ChecksumWrapper checksum, string htmlText, CancellationToken cancellationToken) | ||
| { | ||
| Assumed.True(synchronizationResult.Synchronized); |
Member
Author
There was a problem hiding this comment.
This was the only thing that used the Synchronized field of the passed in result, and the passed in result always hardcoded it to true.
Sometimes it's not good to look back at your past code :)
Contributor
There was a problem hiding this comment.
I experience this a lot, but I just consider PreviousTodd as a completely different idiot than current Todd.
ToddGrun
reviewed
Oct 8, 2025
...Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Cohost/HtmlDocumentPublisher.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this when running our integration tests locally. I've never see the
Debug.Failin real life, and it didn't break the scenario the integration tests were testing, but they failed at the end because they detected that aDebug.Failhad occurred 🤦♂️I think when I originally wrote this might have been before we had synchronization or something, because looking at the code I couldn't see why we would fail and just let Html go stale, rather than just returning false, not synchronizing, and let each feature deal with "the Html LSP request didn't work" in whatever way is best for them.