[release/dev18.0] Fix some issues with our options in the new experience#12263
Merged
davidwengier merged 5 commits intorelease/dev18.0from Sep 25, 2025
Merged
Conversation
| internal static class SettingsNames | ||
| { | ||
| public record Setting(string LegacyName, string UnifiedName); | ||
| public const string UnifiedCollection = "languages.razor.advanced"; |
Member
There was a problem hiding this comment.
This is the most important part. In #12233 I missed changing it to match our json file.
ToddGrun
approved these changes
Sep 24, 2025
Member
|
@dbreshears for M2 mode approval |
dbreshears
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12262 to release/dev18.0
/cc @davidwengier
Customer Impact
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]