Allow tag helper discovery to be cancellable#12258
Merged
DustinCampbell merged 6 commits intodotnet:mainfrom Sep 24, 2025
Merged
Allow tag helper discovery to be cancellable#12258DustinCampbell merged 6 commits intodotnet:mainfrom
DustinCampbell merged 6 commits intodotnet:mainfrom
Conversation
- Add CancellationToken parameter to ITagHelperDescriptorProvider.Execute(...) - Add CancellationToken parameter to ITagHelperFeature.GetDescriptors(...)
We can be less permissive and ensure that the optional "target" symbol passed passed into tag helper discovery is an IAssemblySymbol.
Most of the ITagHelperDescriptorProvider implementations create a Roslyn SymbolVisitor to find candidate types to create TagHelperDescriptors from. This process can be generalized to avoid the SymbolVisitor altogether.
chsienki
approved these changes
Sep 23, 2025
chsienki
reviewed
Sep 23, 2025
src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/TagHelperCollector.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 23, 2025
src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/TagHelperCollector.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 23, 2025
| } | ||
|
|
||
| tagHelpers = tagHelperFeature.GetDescriptors(); | ||
| tagHelpers = tagHelperFeature.GetDescriptors(cancellationToken); |
Contributor
Member
Author
There was a problem hiding this comment.
That'll be a later change. I'm not trying to thread CancellationTokens through all phases yet. Besides, the source generator doesn't pass a token when executing individual phases yet, so that'll need to be done at the same time for it to help.
davidwengier
approved these changes
Sep 23, 2025
src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/TagHelperCollector.cs
Outdated
Show resolved
Hide resolved
DustinCampbell
force-pushed
the
cancellation
branch
from
9a40281 to
fc29abb
Compare
DustinCampbell
force-pushed
the
cancellation
branch
from
fc29abb to
9bde812
Compare
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change threads cancellation through tag helper discovery and ensures that
CancellationTokensare passed when it's called.CI Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2800220&view=results
Test Insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/673094
Toolset Run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2800222&view=results