Share more cohosting tests between VS and VS Code#12204
Merged
davidwengier merged 7 commits intodotnet:mainfrom Sep 10, 2025
Merged
Share more cohosting tests between VS and VS Code#12204davidwengier merged 7 commits intodotnet:mainfrom
davidwengier merged 7 commits intodotnet:mainfrom
Conversation
davidwengier
changed the title
DustinCampbell
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as "Oh, we should share more tests", then became "oh, we're not running these tests on Mac and Linux?", and then a bunch of annoying investigation into why the mac and linux test runs just hung.
Ended up skipping a few tests when not on windows to unblock this. One uses a named pipe which failed reliably, but I think its okay to skip because because a) its testing serialization, not named pipes, b) it's not relevant for cohosting which is on by default in VS Code, and c) I have no idea what I'm doing. The other couple of tests only failed on macOS in release, so might just be flaky, but I feel the last two reasons still apply.