Perf: Cache IsViewComponent results#12201
Merged
ToddGrun merged 3 commits intodotnet:mainfrom Sep 10, 2025
Merged
Conversation
-- will add details if perf run indicates benefits
ToddGrun
changed the title
DustinCampbell
approved these changes
Sep 9, 2025
src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Mvc/ViewComponentTypeVisitor.cs
Outdated
Show resolved
Hide resolved
src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Mvc/ViewComponentTypeVisitor.cs
Outdated
Show resolved
Hide resolved
…it through an extension method on INamedTypeSymbol.
Contributor
Author
|
@DustinCampbell -- Can you take another peek tomorrow and verify this mostly matches your thoughts? |
DustinCampbell
approved these changes
Sep 10, 2025
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
This is good as it is, but I added some feedback to consider.
.../Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Extensions/INamedTypeSymbolExtensions.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Extensions/INamedTypeSymbolExtensions.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Extensions/INamedTypeSymbolExtensions.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Extensions/INamedTypeSymbolExtensions.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Extensions/INamedTypeSymbolExtensions.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Extensions/INamedTypeSymbolExtensions.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Extensions/INamedTypeSymbolExtensions.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache calculation of whether an INamedTypeSymbol represents a view component. Over the 5 speedometer runs I looked at, the existing calculation averaged 2200 ms of total CPU in the Razor cohosting completion speedometer test. A speedometer run with a CWT cache around this calculation, cut the average cost down to 900 ms.
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/668281
*** example old CPU ***
*** example new CPU ***
