Move calculation of TagHelperCollector.MightContainTagHelpers into the cache#12195
Merged
Move calculation of TagHelperCollector.MightContainTagHelpers into the cache#12195
Conversation
…e cache MightContainTagHelpers shows up as 6.6% of CPU in the RoslynCodeAnalysisService process in the html completion scenario in the RazorEditingTests.CompletionInCohosting speedometer test. Going to get a perf run to make sure the increased CWT usage doesn't end up negating the perf benefit.
chsienki
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MightContainTagHelpers shows heavily in CPU profiles in the RoslynCodeAnalysisService process in the RazorEditingTests.CompletionInCohosting speedometer test.
Before, cpu cost was around 8.5 seconds for MightContainTagHelpers and the TagHelperCollector.s_perAssemblyCache CWT. With the change in this PR, the combined CPU cost for the two is around 1.5 seconds.
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/668076
*** Old CPU ***
*** New CPU ***
