Support Task List in cohosting#12181
Conversation
| <MicrosoftCommonLanguageServerProtocolFrameworkPackageVersion>5.0.0-2.25421.11</MicrosoftCommonLanguageServerProtocolFrameworkPackageVersion> | ||
| <MicrosoftNetCompilersToolsetPackageVersion>5.0.0-2.25421.11</MicrosoftNetCompilersToolsetPackageVersion> | ||
| <MicrosoftVisualStudioLanguageServicesPackageVersion>5.0.0-2.25421.11</MicrosoftVisualStudioLanguageServicesPackageVersion> | ||
| <MicrosoftCodeAnalysisAnalyzersPackageVersion>5.0.0-2.25452.2</MicrosoftCodeAnalysisAnalyzersPackageVersion> |
There was a problem hiding this comment.
I assume you meant "why not in Version.props", and the answer is this split came from arcade, so there was one version file for people, and one for automation. See dotnet/arcade-services#4998
The irony is of course, I've only ever manually updated this file, and its xml file twin.
| JsonSerializableRazorPinnedSolutionInfoWrapper solutionInfo, | ||
| JsonSerializableDocumentId documentId, | ||
| ImmutableArray<string> taskListDescriptors, | ||
| LspDiagnostic[] csharpTaskItems, |
There was a problem hiding this comment.
No reason, thats just what the diagnostic translate service takes, presumably because it works directly on a deserialized LSP response, and I carried it through. Is it worth changing, other than for consistency?
There was a problem hiding this comment.
Not worth changing, just consistency and a general appreciation for using ImmutableArrays when possible
| if (generatedDocument is null) | ||
| { | ||
| return []; | ||
| } |
There was a problem hiding this comment.
Would be nice if this code didn't need to know about hintNames. Would it be possible to add an extension to TextDocument so we could just call something like:
var generatedDocument = await razorDocument.TryGetSourceGeneratedDocumentAsync(cancellationToken).ConfigureAwait(false);
There was a problem hiding this comment.
When I wrote diagnostics originally, I was on the fence about making this too easy, because accessing the source generated document in the devenv side of things (where this is) is generally undesirable. In fact, diagnostics and code actions are the only things that should, everything else should be on the remote side.
Having said that, an extension method that can't be called in OOP shouldn't be a problem, especially now that all of the code is written.
There was a problem hiding this comment.
Actually, its only diagnostics, so just a helper method in the base class would work here
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 participants
Fixes #12142 for cohosting
I just completely missed this when I did diagnostics originally, because we get them for free in the LSP editor.