Skip to content

Add missing paren to SyntaxSerializer #11968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjonescz merged 1 commit into from
Jun 24, 2025
Merged

Add missing paren to SyntaxSerializer #11968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Syntax/SyntaxSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ private void WriteNode(SyntaxNode node)

protected virtual void WriteSpan(TextSpan span)
{
WriteValue($"[{span.Start}..{span.End}{Separator}Width: {span.End - span.Start}");
WriteValue($"[{span.Start}..{span.End}){Separator}Width: {span.End - span.Start}");
Copy link
Member

@davidwengier davidwengier Jun 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean this?

Suggested change
WriteValue($"[{span.Start}..{span.End}){Separator}Width: {span.End - span.Start}");
WriteValue($"[{span.Start}..{span.End}]{Separator}Width: {span.End - span.Start}");

Copy link
Member Author

@jjonescz jjonescz Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the end is exclusive. I think we use [x..y) to demonstrate that in other places as well. Definitely we did that here previously:

razor/src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Syntax/SyntaxSerializer.cs

Line 136 in 97c4952

Write($"[{node.Position}..{node.EndPosition})");

Copy link
Member

@davidwengier davidwengier Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, thanks. Looked weird out of context

}

private void WriteRazorDirective(RazorDirectiveSyntax node)
Expand Down
Loading