Client settings tweaks, and implement VS Code configuration monitoring #11800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Apr 29, 2025
src/Razor/src/Microsoft.VisualStudioCode.RazorExtension/Services/ClientSettingsManager.cs
Show resolved
Hide resolved
...src/Microsoft.VisualStudioCode.RazorExtension/Endpoints/CohostConfigurationChangedService.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Hosting/ClaspLoggingBridge.cs
Show resolved
Hide resolved
davidwengier
added a commit
to dotnet/roslyn
that referenced
this pull request
Apr 30, 2025
…#78364) Since Roslyn uses dynamic registration for configuration change requests, Razor can't. Even if we could, as a document-less request, it couldn't be routed to us anyway. So this exposes a hook for us through our EA. Razor side is at dotnet/razor#11800 Part of dotnet/razor#11759
Member
Author
|
Oh what fun, this builds on my machine but not CI, and apparently there are no merges from upstream/main for me to do 🤦♂️ |
Contributor
|
Member
Author
|
Thank you! fortunately was easy enough to fix based on CI errors anyway. I wonder if that indicates a project authoring issue on our end or something? Probably best not the think about it :) |
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11759
This cleans up
IClientSettingsManagerand puts it back to its previous state, removingIClientSettingsReaderat the same time, and also implements a hook for VS Code to get notified when the VS Code configuration changes, and to read the settings as appropriate.Needs a bump to dotnet/roslyn#78364 before it will build