Skip to content

Conversation

@jjonescz
Copy link
Member

@jjonescz jjonescz commented Apr 1, 2025

No description provided.

"Shipping",
"NonShipping"
],
"vsBranch": "main",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems wrong. Should be the same as Roslyn, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean, this will be the same as Roslyn.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was looking at Roslyn's earlier today and I thought it was set to the "initial" branch, but I guess that pre-snap anyway. I'm sure you know what you're doing better than me :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, after VS snaps, I think main is the correct target branch rather than the "initial" one.

@jjonescz jjonescz marked this pull request as ready for review April 1, 2025 09:17
@jjonescz jjonescz requested review from a team as code owners April 1, 2025 09:17
@jjonescz jjonescz merged commit 93d4a98 into dotnet:main Apr 1, 2025
11 checks passed
@jjonescz jjonescz deleted the snap-17.14p3-config branch April 1, 2025 09:17
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 1, 2025
@ryzngard ryzngard mentioned this pull request Apr 18, 2025
@ryzngard ryzngard mentioned this pull request Apr 28, 2025
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants