Skip to content

Update Ngen Priorities for VS #11662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwengier merged 4 commits into from
Mar 27, 2025
Merged

Update Ngen Priorities for VS #11662

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f06d1db
Adjust ngen priorities
Mar 26, 2025
e550f9e
Merge branch 'dotnet:main' into main
AlexDelepine Mar 26, 2025
5f5883b
Get rid of RazorNgendVSIXSourceItem
Mar 27, 2025
3b08917
Merge branch 'main' of https://github.com/AlexDelepine/razor
Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...or/src/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@
<!-- Don't trim this list. It is used to feed into the binding redirects -->
<ProjectReference Include="$(SharedSourceRoot)\Microsoft.AspNetCore.Razor.Utilities.Shared\Microsoft.AspNetCore.Razor.Utilities.Shared.csproj">
<AdditionalProperties>TargetFramework=$(NetFxVS)</AdditionalProperties>
<NgenPriority>2</NgenPriority>
</ProjectReference>
<ProjectReference Include="..\Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor\Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.csproj" />

Expand Down Expand Up @@ -194,7 +195,9 @@
<Ngen>false</Ngen>
</ProjectReference>
<ProjectReference Include="..\Microsoft.VisualStudio.LanguageServer.ContainedLanguage\Microsoft.VisualStudio.LanguageServer.ContainedLanguage.csproj" />
<ProjectReference Include="..\Microsoft.VisualStudio.LanguageServices.Razor\Microsoft.VisualStudio.LanguageServices.Razor.csproj" />
<ProjectReference Include="..\Microsoft.VisualStudio.LanguageServices.Razor\Microsoft.VisualStudio.LanguageServices.Razor.csproj" >
<NgenPriority>1</NgenPriority>
</ProjectReference>
<ProjectReference Include="..\Microsoft.VisualStudio.LegacyEditor.Razor\Microsoft.VisualStudio.LegacyEditor.Razor.csproj" />
<ProjectReference Include="..\..\..\Compiler\Microsoft.CodeAnalysis.Razor.Compiler\src\Microsoft.CodeAnalysis.Razor.Compiler.csproj">
<Name>Microsoft.CodeAnalysis.Razor.Compiler</Name>
Expand Down Expand Up @@ -226,7 +229,7 @@
<Ngen>$(Ngen)</Ngen>
<NgenApplication>$(NgenApplication)</NgenApplication>
<NgenArchitecture>$(NgenArchitecture)</NgenArchitecture>
<NgenPriority>$(NgenPriority)</NgenPriority>
<NgenPriority>1</NgenPriority>
</VSIXSourceItem>
Copy link
Member

@davidwengier davidwengier Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking this change makes all RazorNgendVSIXSourceItem items be priority 1. As it happens, there is only one of those left after some other changes, so I think we should just get rid of the entire RazorNgendVSIXSourceItem concept, above this. I think lines 226 to 233 could just be replaced with:

<VSIXSourceItem Include="$(OutputPath)Microsoft.CodeAnalysis.Razor.Compiler.dll">
  <NgenPriority>1</NgenPriority>
</VSIXSourceItem>

Copy link
Contributor Author

@AlexDelepine AlexDelepine Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got rid of the RazorNgendVSIXSourceItem, I also had to add a <Ngen>true</Ngen> in there, but the output is now identical to what it was with RazorNgendVSIXSourceItem .

</ItemGroup>

Expand Down