Switch to embedded PackageIcon #1164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
requested review from
NTaylorMullen,
ajaybhargavb,
pranavkm and
rynowak
as code owners
rynowak
approved these changes
Sep 24, 2019
Member
Author
|
With the last change, this now includes the icon metadata in all .nuspec's, including the manually generated ones - @dougbu PTAL |
dougbu
approved these changes
Sep 24, 2019
Contributor
|
Please retarget this change to 'release/3.0'. We'll need to do something a bit different in 2.x. |
Member
Author
|
Closing in favor of #1166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of aspnet/AspNetCore-Internal#3146
Local build passes the smell test with these changes.