Skip to content

Revert symbol related changes (for now) #11568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Revert symbol related changes (for now) #11568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
075a5c9
Revert "Produce more symbols (#11563)"
phil-allen-msft Feb 27, 2025
1c9aa36
Revert "Improve build reliability by removing conversion to Windows P…
phil-allen-msft Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>

<!-- VS does not require Windows PDBs to be published anymore. -->
<PublishWindowsPdb>false</PublishWindowsPdb>

<SharedSourceRoot>$(MSBuildThisFileDirectory)src\Shared\</SharedSourceRoot>
<SharedFilesRoot>$(SharedSourceRoot)files\</SharedFilesRoot>

Expand Down
3 changes: 3 additions & 0 deletions src/Analyzers/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
<IncludeSymbols>true</IncludeSymbols>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>

<!-- In theory we want to have this property set, but our pipeline doesn't set the access tokens yet -->
<PublishWindowsPdb Condition="'$(DotNetSymbolServerTokenMsdl)'!='' and '$(DotNetSymbolServerTokenSymWeb)'!=''">true</PublishWindowsPdb>

<RollForward Condition="'$(IsTestProject)' == 'true'">LatestMajor</RollForward>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion ...er/Microsoft.CodeAnalysis.Razor.Compiler/src/Microsoft.CodeAnalysis.Razor.Compiler.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<Description>Razor is a markup syntax for adding server-side logic to web pages. This package contains the Razor compiler.</Description>
<TargetFrameworks>$(DefaultNetCoreTargetFramework);netstandard2.0</TargetFrameworks>
<ExcludeFromSourceOnlyBuild>false</ExcludeFromSourceOnlyBuild>
<IsShippingAssembly>true</IsShippingAssembly>

<!--
RS2008: Enable analyzer release tracking
Expand Down
2 changes: 2 additions & 0 deletions src/Razor/src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
<IncludeSymbols>true</IncludeSymbols>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>

<!-- In theory we want to have this property set, but our pipeline doesn't set the access tokens yet -->
<PublishWindowsPdb Condition="'$(DotNetSymbolServerTokenMsdl)'!='' and '$(DotNetSymbolServerTokenSymWeb)'!=''">true</PublishWindowsPdb>
</PropertyGroup>

</Project>
1 change: 0 additions & 1 deletion ...or/src/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
<VSToolsPath Condition="'$(VSToolsPath)' == ''">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)</VSToolsPath>
<ExcludeFromSourceOnlyBuild>true</ExcludeFromSourceOnlyBuild>
<IsPackable>false</IsPackable>
<IsShippingAssembly>true</IsShippingAssembly>

<GenerateResourceUsePreserializedResources Condition="'$(MSBuildRuntimeType)' == 'Core'">true</GenerateResourceUsePreserializedResources>

Expand Down
3 changes: 3 additions & 0 deletions src/Shared/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
<IncludeSymbols>true</IncludeSymbols>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>

<!-- In theory we want to have this property set, but our pipeline doesn't set the access tokens yet -->
<PublishWindowsPdb Condition="'$(DotNetSymbolServerTokenMsdl)'!='' and '$(DotNetSymbolServerTokenSymWeb)'!=''">true</PublishWindowsPdb>

<RollForward Condition="'$(IsTestProject)' == 'true'">LatestMajor</RollForward>
</PropertyGroup>

Expand Down