Remove ImportDocumentSnapshot and (finally) fix nullability annotations on IDocumentSnapshot #11184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment explaining why this DocumentState method is internal seems to be out of date. It's currently only used within DocumentState, so this change removes the comment and makes it private.
When computing the ImportItems for a given document, we shouldn't need to compute an intermediary array of document snapshots.
This change removes several parameters from DocumentState.GenerateCodeDocumentAsync(...) and computes them internally. So, there's no longer a need to expose GetImportsAsync for GenerateCodeDocumetnAsync callers.
For a long while IDocumentSnapshot's FileKind, FilePath, and TargetPath properties have all been annotated as nullable. It turns out that the only reason for this was ImportDocumentSnapshot, which has been removed. So, we can now allow these properties to be correctly annotated as non-nullable,
davidwengier
approved these changes
Nov 8, 2024
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
Thank you for making FilePath and friends non nullable! Worth its weight in gold
| IDocumentSnapshot document, | ||
| RazorProjectItem? projectItem, | ||
| CancellationToken cancellationToken) | ||
| private static async Task<RazorSourceDocument> GetSourceAsync(IDocumentSnapshot document, RazorProjectEngine projectEngine, CancellationToken cancellationToken) |
Member
There was a problem hiding this comment.
Might not be worth it, but if this method took string filePath, string fileKind, SourceText text, then it could be called from inside the loop in GetImportSources too (and become sync.
Member
Author
There was a problem hiding this comment.
I'll definitely take a look at that in my next PR in this space.
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit-by-commit is the way. 😄