Add co-hosting support for hover #11150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Nov 5, 2024
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
Nifty raw content validation
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Hover/RemoteHoverService.cs
Outdated
Show resolved
Hide resolved
Rework the logic in RemoteHoverService. It isn't necessary to try and map the host document index to C#, since `GetPositionInfo(..., preferCSharpOverHtml: true)`already does that for us.
davidwengier
reviewed
Nov 5, 2024
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Hover/RemoteHoverService.cs
Outdated
Show resolved
Hide resolved
Member
|
FYI I merged #11151 so you'll want to merge main, as |
Member
Author
No worries! Thanks for the heads up! I'll get it fixed up. |
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10839
Now that all of the infrastructure is in place, adding a co-hosting endpoint and remote service for Hover is mostly boilerplate. Similar to the signature help endpoint, the result type might be a Roslyn LSP Hover or a VS LSP Hover. The remote service always returns a Roslyn LSP Hover, but HTML will return a VS LSP Hover. So, we join the possibilities together with a SumType.