-
Notifications
You must be signed in to change notification settings - Fork 229
Cohost code actions #11147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidwengier
merged 23 commits into
dotnet:main
from
davidwengier:dev/dawengie/CodeActionsPart5
Nov 7, 2024
Merged
Cohost code actions #11147
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3376535
Create basic cohosting infrastrcuture
davidwengier 6f61999
Complete cohosting code actions functionality
davidwengier 61ca99b
Report better MEF composition errors in tests
davidwengier 60ed8c0
Add delegated document Uri to code action data
davidwengier e829ffb
Add cohost resolve endpoint and tests
davidwengier b509f67
Fix code action translation to Roslyn types
davidwengier a813c22
Move helpers to base class
davidwengier 8ba2bbf
Implement additional roslyn helpers, and add tests for more involved …
davidwengier 0a3b902
Cohost eqivalent of https://github.com/dotnet/razor/pull/11141
davidwengier d7e1c01
Silly mistake number 1
davidwengier 4ef1668
Bump Roslyn to 4.13.0-2.24554.8
davidwengier a217d9f
Merge remote-tracking branch 'upstream/main' into dev/dawengie/CodeAc…
davidwengier 9b09b25
Update tests. No idea why these weren't failing to compile on my mach…
davidwengier 673f828
Seal endpoints (silly mistake 2?)
davidwengier 7338393
Update compiler test baselines
davidwengier 39138eb
Merge remote-tracking branch 'upstream/main' into dev/dawengie/CodeAc…
davidwengier 61b5d93
PR Feedback
davidwengier 04da689
Merge remote-tracking branch 'upstream/main' into dev/dawengie/CodeAc…
davidwengier 706dc93
FIx code actions resolve in VS.
davidwengier 15c0333
Fix registration after merge
davidwengier 6cd3c63
Fix namespace on test
davidwengier aebf195
Tweak roslyn helpers and nullability
davidwengier 31469c4
Further tweak Roslyn helpers
davidwengier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
20 changes: 10 additions & 10 deletions
20
...ts/ComponentDesignTimePreprocessorDirectiveTest/StartOfLine_08/TestComponent.mappings.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,18 @@ | ||
| Source Location: (2:0,2 [13] x:\dir\subdir\Test\TestComponent.razor) | ||
| Source Location: (2:0,2 [13] x:\dir\subdir\Test\TestComponent.razor) | ||
| | | ||
| #if true | ||
| | | ||
| Generated Location: (986:28,2 [13] ) | ||
| | | ||
| Generated Location: (986:28,2 [13] ) | ||
| | | ||
| #if true | ||
| | | ||
|
|
||
| Source Location: (20:3,2 [11] x:\dir\subdir\Test\TestComponent.razor) | ||
| | | ||
| Source Location: (20:3,2 [11] x:\dir\subdir\Test\TestComponent.razor) | ||
| | | ||
| #endif | ||
| | | ||
| Generated Location: (1120:36,2 [11] ) | ||
| | | ||
| Generated Location: (1120:36,2 [11] ) | ||
| | | ||
| #endif | ||
| | | ||
|
|
||
| | | ||
20 changes: 10 additions & 10 deletions
20
...Tests/ComponentRuntimePreprocessorDirectiveTest/StartOfLine_08/TestComponent.mappings.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,18 @@ | ||
| Source Location: (2:0,2 [13] x:\dir\subdir\Test\TestComponent.razor) | ||
| Source Location: (2:0,2 [13] x:\dir\subdir\Test\TestComponent.razor) | ||
| | | ||
| #if true | ||
| | | ||
| Generated Location: (733:21,0 [13] ) | ||
| | | ||
| Generated Location: (733:21,0 [13] ) | ||
| | | ||
| #if true | ||
| | | ||
|
|
||
| Source Location: (20:3,2 [11] x:\dir\subdir\Test\TestComponent.razor) | ||
| | | ||
| Source Location: (20:3,2 [11] x:\dir\subdir\Test\TestComponent.razor) | ||
| | | ||
| #endif | ||
| | | ||
| Generated Location: (877:30,0 [11] ) | ||
| | | ||
| Generated Location: (877:30,0 [11] ) | ||
| | | ||
| #endif | ||
| | | ||
|
|
||
| | | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like result of dotnet/roslyn#75549.