Skip to content

Conversation

@alexgav
Copy link
Contributor

@alexgav alexgav commented Sep 19, 2024

We now wait for a specific item in the actual shown completion UI, and also wait for the correct text in the editor post-commit to account for actions such as OnAutoInsert

  1. We now actually open completion UI. Previously we may or may not have had the UI open, because IAsyncCompletionBroker.TriggerCompletion doesn't actually cause completion pop-up window UI to show (at least per doc comments). IAsyncCompletionSession.OpenOrUpdate actually shows completion window UI.
  2. We now wait for a specified item to be present and selected prior to trying to commit. We will re-update (re-calculate) completion items while waiting.
  3. We now wait for the correct text to be in the editor. After completion commit, there may be another action, such as OnAutoInsert that may modify the text further. We specify the final expected state of the text, so we should wait for it to be fully updated.

@alexgav alexgav requested a review from a team as a code owner September 19, 2024 20:28
@alexgav
Copy link
Contributor Author

alexgav commented Sep 20, 2024

Now passing 5 out of 5 times on CI

@alexgav alexgav changed the base branch from main to release/dev17.12 September 25, 2024 21:32
@alexgav alexgav requested a review from a team as a code owner September 25, 2024 21:32
@alexgav alexgav changed the base branch from release/dev17.12 to main September 25, 2024 21:44
We not wait for a specific item in the actual shown completion UI, and also wait for the correct text in the editor post-commit to account for actions such as OnAutoInsert
@alexgav alexgav force-pushed the dev/alexgav/HardenCompletionTestMore branch from 443757c to 12286cb Compare September 25, 2024 22:19
@alexgav alexgav changed the base branch from main to release/dev17.12 September 25, 2024 22:20
@alexgav alexgav merged commit 4ccb0ab into release/dev17.12 Sep 25, 2024
@alexgav alexgav deleted the dev/alexgav/HardenCompletionTestMore branch September 25, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants