Remove unnecessary dependencies from formatting #10363
Conversation
| _documentMappingService = documentMappingService; | ||
| _clientConnection = clientConnection; | ||
| } | ||
| private readonly IRazorDocumentMappingService _documentMappingService = documentMappingService; |
There was a problem hiding this comment.
Since you're removing the ArgumentNullException, could IRazorDocumentMappingService ever be null?
There was a problem hiding this comment.
This class is directly constructed in code, so nullable reference types protects us from ever passing in null. If it was created by DI, then both of the DI technologies we use would throw errors during composition/container creation and never get this far anyway.
There was a problem hiding this comment.
The fact that both MEF and MS.Ext.DependencyInjection already protect against null is a good one to remember. We have lots of services and endpoints that validate against null arguments that are wholly unnecessary. As more and more code is nullable enabled (most of tooling is and most of the compiler is not), removing unnecessary ArgumentNullExceptions gets a thumbs up from me.
5 participants
All of our formatting passes took an
IClientConnectionbut only Html actually uses it. Cleaning this up gives us a more accurate picture for cohosting.