YAPCSSF: Yet Another ProjectConfigurationStateSynchronizer fix #10332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, the dictionary to map configuration file paths to project keys isn't needed. Currently, the configuration file is in the project's intermediate output path, which *is* the project key.
Member
|
At the next razor design meeting I think we should all take a turn trying to pronounce YAPCSSF. :) |
davidwengier
added a commit
that referenced
this pull request
May 2, 2024
…#10335) Fixes #10306 This change takes a different approach than #10308 and #10330 and #10332 because life was meant to be interesting. The original problem we were trying to solve is that when a Reset then Add came in, we would migrate all of the documents out of the project, then migrate them all back in again. The various solutions in the other PRs you can read about at your leisure, this one takes a rather simple approach: 1. Ignore everything but the most recent update for a specific project 2. If we need to update a project, but it doesn't exist, add it In the long run we should remove `IRazorProjectService.AddProjectAsync` entirely, and rename `IRazorProjectService.UpdateProjectAsync` to `ResetProjectAsync`, but doing that now would just conflict with other open PRs.
Member
Author
|
Closing this PR since @davidwengier won |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10306
This change takes a different approach than #10308 and #10330. The problem that all of these are trying to fix is to ensure that "add" or "change" events for configuration file for an unknown project result in a project add at the correct time. The timing details are in #10306.
The timing problem occurs because the project should be added before any other enqueued resets or updates run. However, recent changes to use an
AsyncBatchingWorkQueuemade all work happen in the same batch, including work to add missing projects. This change pulls project adds out of the work queue and just adds them immediately. This takes advantage of the fact that theProjectSnapshotManagerhandles operations in a queue, so the project add will happen before any resets or updates. This is effectively howProjectConfigurationChangeSynchronizerworked before, but this change keeps the batching work queue for project resets and updates.