Consolidate various extension methods in Workspaces #10042
Conversation
Purely mechanical, just copied and pasted files in Explorer :)
These were previously a transitive dependency in the language server, via the ContainedLanguage DLL. We already ship them in VS Code and VS.
Everything that needs these types already references LanguageServer and Workspaces
And in a couple of places, the existing ToRange method instead of the project-specific AsRange method which did the same thing :)
|
Integration test run is https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9203177&view=results but it won't show up in GitHub because it's before a rebase, so the commit hash is different. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Integration tests passed, except the MEF validation test, which is being fixed in #10044 |
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
The mechanical changes look good. However, I'd prefer that we don't further couple the LanguageServer project to VS, since I'm actively trying to break that dependency because it's already making a mess of the co-hosting effort. Instead, could you move all of the protocol types that were moved to LanguageServer to a "Protocol" folder in Workspaces? That way, we can get rid of the project without coupling further.
|
No argument from me. I will have to move |
This is a highly mechanical PR, but its also big, so commit-at-a-time is probably best. This moves our extension methods that deal with LSP types, Roslyn types, and Razor types, to the Workspaces layer so that cohosting can use them in OOP. And also general cleanliness, because we had them scattered around and I never knew where to put new ones :)
Part of #9519