[release/dev17.10] Avoid force-creating the project snapshot manager off the dispatcher #10026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CSharpVirtualDocumentFactory` unnecessarily forces the `ProjectSnapshotManager` to be created just to see if it contains any projects. To avoid this, I've added a `TryGetInstance(...)` method that returns the `ProjectSnapshotManager` only if it has been created. Then, in `CSharpVirtualDocumentFactory` it avoids force-creating the `ProjectSnapshotManager` if `TryGetInstance(...)` returns false.
davidwengier
approved these changes
Mar 4, 2024
ryzngard
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the changes from #10024 to the
release/dev17.10, since there's interest in these changes for 17.10p2.