Skip to content

Commit 076ec28

Browse files
davidwengierdavidwengier
authored
Various follow ups from Roslyn features (#12435)
Three things I've been tracking from Roslyn: 1. Auto insert support for raw string literals: dotnet/roslyn#80871 2. Line Folding Only support in VS Code: dotnet/roslyn#80955 (fixes #12414) * We already did this in our folding range response anyway 3. Allow FormattingLogTest can use real types, and remove our temporary equivalent
2 parents c5842d3 + e83bede commit 076ec28

File tree

16 files changed

+171
-160
lines changed

16 files changed

+171
-160
lines changed

‎eng/Version.Details.props‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,27 @@ This file should be imported by eng/Versions.props
66
<Project>
77
<PropertyGroup>
88
<!-- dotnet/roslyn dependencies -->
9-
<MicrosoftCodeAnalysisAnalyzersPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisAnalyzersPackageVersion>
10-
<MicrosoftCodeAnalysisCommonPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisCommonPackageVersion>
11-
<MicrosoftCodeAnalysisCSharpPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisCSharpPackageVersion>
12-
<MicrosoftCodeAnalysisCSharpEditorFeaturesPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisCSharpEditorFeaturesPackageVersion>
13-
<MicrosoftCodeAnalysisCSharpFeaturesPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisCSharpFeaturesPackageVersion>
14-
<MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion>
15-
<MicrosoftCodeAnalysisEditorFeaturesPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisEditorFeaturesPackageVersion>
16-
<MicrosoftCodeAnalysisEditorFeaturesCommonPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisEditorFeaturesCommonPackageVersion>
17-
<MicrosoftCodeAnalysisEditorFeaturesTextPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisEditorFeaturesTextPackageVersion>
18-
<MicrosoftCodeAnalysisExternalAccessFSharpPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisExternalAccessFSharpPackageVersion>
19-
<MicrosoftCodeAnalysisExternalAccessRazorEditorFeaturesPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisExternalAccessRazorEditorFeaturesPackageVersion>
20-
<MicrosoftCodeAnalysisExternalAccessRazorFeaturesPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisExternalAccessRazorFeaturesPackageVersion>
21-
<MicrosoftCodeAnalysisLanguageServerProtocolPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisLanguageServerProtocolPackageVersion>
22-
<MicrosoftCodeAnalysisRemoteServiceHubPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisRemoteServiceHubPackageVersion>
23-
<MicrosoftCodeAnalysisTestUtilitiesPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisTestUtilitiesPackageVersion>
24-
<MicrosoftCodeAnalysisVisualBasicWorkspacesPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisVisualBasicWorkspacesPackageVersion>
25-
<MicrosoftCodeAnalysisWorkspacesCommonPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisWorkspacesCommonPackageVersion>
26-
<MicrosoftCodeAnalysisWorkspacesMSBuildPackageVersion>5.0.0-2.25461.22</MicrosoftCodeAnalysisWorkspacesMSBuildPackageVersion>
27-
<MicrosoftCommonLanguageServerProtocolFrameworkPackageVersion>5.0.0-2.25461.22</MicrosoftCommonLanguageServerProtocolFrameworkPackageVersion>
28-
<MicrosoftNetCompilersToolsetPackageVersion>5.0.0-2.25461.22</MicrosoftNetCompilersToolsetPackageVersion>
29-
<MicrosoftVisualStudioLanguageServicesPackageVersion>5.0.0-2.25461.22</MicrosoftVisualStudioLanguageServicesPackageVersion>
9+
<MicrosoftCodeAnalysisAnalyzersPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisAnalyzersPackageVersion>
10+
<MicrosoftCodeAnalysisCommonPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisCommonPackageVersion>
11+
<MicrosoftCodeAnalysisCSharpPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisCSharpPackageVersion>
12+
<MicrosoftCodeAnalysisCSharpEditorFeaturesPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisCSharpEditorFeaturesPackageVersion>
13+
<MicrosoftCodeAnalysisCSharpFeaturesPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisCSharpFeaturesPackageVersion>
14+
<MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion>
15+
<MicrosoftCodeAnalysisEditorFeaturesPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisEditorFeaturesPackageVersion>
16+
<MicrosoftCodeAnalysisEditorFeaturesCommonPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisEditorFeaturesCommonPackageVersion>
17+
<MicrosoftCodeAnalysisEditorFeaturesTextPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisEditorFeaturesTextPackageVersion>
18+
<MicrosoftCodeAnalysisExternalAccessFSharpPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisExternalAccessFSharpPackageVersion>
19+
<MicrosoftCodeAnalysisExternalAccessRazorEditorFeaturesPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisExternalAccessRazorEditorFeaturesPackageVersion>
20+
<MicrosoftCodeAnalysisExternalAccessRazorFeaturesPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisExternalAccessRazorFeaturesPackageVersion>
21+
<MicrosoftCodeAnalysisLanguageServerProtocolPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisLanguageServerProtocolPackageVersion>
22+
<MicrosoftCodeAnalysisRemoteServiceHubPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisRemoteServiceHubPackageVersion>
23+
<MicrosoftCodeAnalysisTestUtilitiesPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisTestUtilitiesPackageVersion>
24+
<MicrosoftCodeAnalysisVisualBasicWorkspacesPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisVisualBasicWorkspacesPackageVersion>
25+
<MicrosoftCodeAnalysisWorkspacesCommonPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisWorkspacesCommonPackageVersion>
26+
<MicrosoftCodeAnalysisWorkspacesMSBuildPackageVersion>5.3.0-1.25530.6</MicrosoftCodeAnalysisWorkspacesMSBuildPackageVersion>
27+
<MicrosoftCommonLanguageServerProtocolFrameworkPackageVersion>5.3.0-1.25530.6</MicrosoftCommonLanguageServerProtocolFrameworkPackageVersion>
28+
<MicrosoftNetCompilersToolsetPackageVersion>5.3.0-1.25530.6</MicrosoftNetCompilersToolsetPackageVersion>
29+
<MicrosoftVisualStudioLanguageServicesPackageVersion>5.3.0-1.25530.6</MicrosoftVisualStudioLanguageServicesPackageVersion>
3030
<!-- dotnet/arcade dependencies -->
3131
<MicrosoftDotNetArcadeSdkPackageVersion>9.0.0-beta.25515.2</MicrosoftDotNetArcadeSdkPackageVersion>
3232
<!-- dotnet/aspnetcore dependencies -->

‎eng/Version.Details.xml‎

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -2,89 +2,89 @@
22
<Dependencies>
33
<Source Uri="https://github.com/dotnet/dotnet" Mapping="razor" Sha="1bdc5cdcf4cf408e00aa3c60f58520083bf2474f" BarId="287856" />
44
<ProductDependencies>
5-
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="5.0.0-2.25461.22">
5+
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="5.3.0-1.25530.6">
66
<Uri>https://github.com/dotnet/roslyn</Uri>
7-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
7+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
88
</Dependency>
9-
<Dependency Name="Microsoft.CommonLanguageServerProtocol.Framework" Version="5.0.0-2.25461.22">
9+
<Dependency Name="Microsoft.CommonLanguageServerProtocol.Framework" Version="5.3.0-1.25530.6">
1010
<Uri>https://github.com/dotnet/roslyn</Uri>
11-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
11+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
1212
</Dependency>
13-
<Dependency Name="Microsoft.CodeAnalysis.Common" Version="5.0.0-2.25461.22">
13+
<Dependency Name="Microsoft.CodeAnalysis.Common" Version="5.3.0-1.25530.6">
1414
<Uri>https://github.com/dotnet/roslyn</Uri>
15-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
15+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
1616
</Dependency>
17-
<Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="5.0.0-2.25461.22">
17+
<Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="5.3.0-1.25530.6">
1818
<Uri>https://github.com/dotnet/roslyn</Uri>
19-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
19+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
2020
</Dependency>
21-
<Dependency Name="Microsoft.CodeAnalysis.CSharp.EditorFeatures" Version="5.0.0-2.25461.22">
21+
<Dependency Name="Microsoft.CodeAnalysis.CSharp.EditorFeatures" Version="5.3.0-1.25530.6">
2222
<Uri>https://github.com/dotnet/roslyn</Uri>
23-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
23+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
2424
</Dependency>
25-
<Dependency Name="Microsoft.CodeAnalysis.CSharp.Features" Version="5.0.0-2.25461.22">
25+
<Dependency Name="Microsoft.CodeAnalysis.CSharp.Features" Version="5.3.0-1.25530.6">
2626
<Uri>https://github.com/dotnet/roslyn</Uri>
27-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
27+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
2828
</Dependency>
29-
<Dependency Name="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="5.0.0-2.25461.22">
29+
<Dependency Name="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="5.3.0-1.25530.6">
3030
<Uri>https://github.com/dotnet/roslyn</Uri>
31-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
31+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
3232
</Dependency>
33-
<Dependency Name="Microsoft.CodeAnalysis.EditorFeatures" Version="5.0.0-2.25461.22">
33+
<Dependency Name="Microsoft.CodeAnalysis.EditorFeatures" Version="5.3.0-1.25530.6">
3434
<Uri>https://github.com/dotnet/roslyn</Uri>
35-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
35+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
3636
</Dependency>
37-
<Dependency Name="Microsoft.CodeAnalysis.EditorFeatures.Common" Version="5.0.0-2.25461.22">
37+
<Dependency Name="Microsoft.CodeAnalysis.EditorFeatures.Common" Version="5.3.0-1.25530.6">
3838
<Uri>https://github.com/dotnet/roslyn</Uri>
39-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
39+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
4040
</Dependency>
41-
<Dependency Name="Microsoft.CodeAnalysis.EditorFeatures.Text" Version="5.0.0-2.25461.22">
41+
<Dependency Name="Microsoft.CodeAnalysis.EditorFeatures.Text" Version="5.3.0-1.25530.6">
4242
<Uri>https://github.com/dotnet/roslyn</Uri>
43-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
43+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
4444
</Dependency>
45-
<Dependency Name="Microsoft.CodeAnalysis.Remote.ServiceHub" Version="5.0.0-2.25461.22">
45+
<Dependency Name="Microsoft.CodeAnalysis.Remote.ServiceHub" Version="5.3.0-1.25530.6">
4646
<Uri>https://github.com/dotnet/roslyn</Uri>
47-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
47+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
4848
</Dependency>
49-
<Dependency Name="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="5.0.0-2.25461.22">
49+
<Dependency Name="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="5.3.0-1.25530.6">
5050
<Uri>https://github.com/dotnet/roslyn</Uri>
51-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
51+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
5252
</Dependency>
53-
<Dependency Name="Microsoft.CodeAnalysis.Workspaces.Common" Version="5.0.0-2.25461.22">
53+
<Dependency Name="Microsoft.CodeAnalysis.Workspaces.Common" Version="5.3.0-1.25530.6">
5454
<Uri>https://github.com/dotnet/roslyn</Uri>
55-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
55+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
5656
</Dependency>
57-
<Dependency Name="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="5.0.0-2.25461.22">
57+
<Dependency Name="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="5.3.0-1.25530.6">
5858
<Uri>https://github.com/dotnet/roslyn</Uri>
59-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
59+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
6060
</Dependency>
61-
<Dependency Name="Microsoft.VisualStudio.LanguageServices" Version="5.0.0-2.25461.22">
61+
<Dependency Name="Microsoft.VisualStudio.LanguageServices" Version="5.3.0-1.25530.6">
6262
<Uri>https://github.com/dotnet/roslyn</Uri>
63-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
63+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
6464
</Dependency>
65-
<Dependency Name="Microsoft.CodeAnalysis.Test.Utilities" Version="5.0.0-2.25461.22">
65+
<Dependency Name="Microsoft.CodeAnalysis.Test.Utilities" Version="5.3.0-1.25530.6">
6666
<Uri>https://github.com/dotnet/roslyn</Uri>
67-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
67+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
6868
</Dependency>
69-
<Dependency Name="Microsoft.CodeAnalysis.ExternalAccess.Razor.Features" Version="5.0.0-2.25461.22">
69+
<Dependency Name="Microsoft.CodeAnalysis.ExternalAccess.Razor.Features" Version="5.3.0-1.25530.6">
7070
<Uri>https://github.com/dotnet/roslyn</Uri>
71-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
71+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
7272
</Dependency>
73-
<Dependency Name="Microsoft.CodeAnalysis.ExternalAccess.Razor.EditorFeatures" Version="5.0.0-2.25461.22">
73+
<Dependency Name="Microsoft.CodeAnalysis.ExternalAccess.Razor.EditorFeatures" Version="5.3.0-1.25530.6">
7474
<Uri>https://github.com/dotnet/roslyn</Uri>
75-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
75+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
7676
</Dependency>
77-
<Dependency Name="Microsoft.CodeAnalysis.LanguageServer.Protocol" Version="5.0.0-2.25461.22">
77+
<Dependency Name="Microsoft.CodeAnalysis.LanguageServer.Protocol" Version="5.3.0-1.25530.6">
7878
<Uri>https://github.com/dotnet/roslyn</Uri>
79-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
79+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
8080
</Dependency>
81-
<Dependency Name="Microsoft.CodeAnalysis.ExternalAccess.FSharp" Version="5.0.0-2.25461.22">
81+
<Dependency Name="Microsoft.CodeAnalysis.ExternalAccess.FSharp" Version="5.3.0-1.25530.6">
8282
<Uri>https://github.com/dotnet/roslyn</Uri>
83-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
83+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
8484
</Dependency>
85-
<Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="5.0.0-2.25461.22">
85+
<Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0-1.25530.6">
8686
<Uri>https://github.com/dotnet/roslyn</Uri>
87-
<Sha>e3cf188c71ec62089866f0e99bd535cd47878659</Sha>
87+
<Sha>d9459428c3065525eeb740fa8cd7ce6b83c8b550</Sha>
8888
</Dependency>
8989
</ProductDependencies>
9090
<ToolsetDependencies>

‎src/Compiler/Microsoft.AspNetCore.Razor.Language/test/TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await_DesignTime.cs-diagnostics.txt‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await.cshtml(2,31): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
2-
// public async Task<string> Foo()
3-
Diagnostic(ErrorCode.WRN_AsyncLacksAwaits, "Foo").WithLocation(2, 31),
4-
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await.cshtml(14,55): error CS1525: Invalid expression term ';'
1+
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await.cshtml(14,55): error CS1525: Invalid expression term ';'
52
// __o = await;
63
Diagnostic(ErrorCode.ERR_InvalidExprTerm, ";").WithArguments(";").WithLocation(14, 55),
74
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await.cshtml(19,49): error CS1501: No overload for method 'Foo' takes 2 arguments

‎src/Compiler/Microsoft.AspNetCore.Razor.Language/test/TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await_Runtime.cs-diagnostics.txt‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await.cshtml(2,31): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
2-
// public async Task<string> Foo()
3-
Diagnostic(ErrorCode.WRN_AsyncLacksAwaits, "Foo").WithLocation(2, 31),
4-
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await.cshtml(14,55): error CS1525: Invalid expression term ')'
1+
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await.cshtml(14,55): error CS1525: Invalid expression term ')'
52
// await
63
Diagnostic(ErrorCode.ERR_InvalidExprTerm, "").WithArguments(")").WithLocation(14, 55),
74
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Await.cshtml(19,49): error CS1501: No overload for method 'Foo' takes 2 arguments

‎src/Compiler/Microsoft.AspNetCore.Razor.Language/test/TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Markup_InCodeBlocksWithTagHelper_Runtime.cs-diagnostics.txt‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ Diagnostic(ErrorCode.ERR_BadAwaitWithoutVoidAsyncMethod, "await __tagHelperRunne
44
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Markup_InCodeBlocksWithTagHelper.cshtml(81,17): error CS4033: The 'await' operator can only be used within an async method. Consider marking this method with the 'async' modifier and changing its return type to 'Task'.
55
// await __tagHelperExecutionContext.SetOutputContentAsync();
66
Diagnostic(ErrorCode.ERR_BadAwaitWithoutVoidAsyncMethod, "await __tagHelperExecutionContext.SetOutputContentAsync()").WithLocation(81, 17),
7-
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Markup_InCodeBlocksWithTagHelper.cshtml(126,193): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
8-
// __tagHelperExecutionContext = __tagHelperScopeManager.Begin("div", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "__UniqueIdSuppressedForTesting__", async() => {
9-
Diagnostic(ErrorCode.WRN_AsyncLacksAwaits, "=>").WithLocation(126, 193),
107
// TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Markup_InCodeBlocksWithTagHelper.cshtml(142,9): error CS4032: The 'await' operator can only be used within an async method. Consider marking this method with the 'async' modifier and changing its return type to 'Task<Task>'.
118
// await __tagHelperRunner.RunAsync(__tagHelperExecutionContext);
129
Diagnostic(ErrorCode.ERR_BadAwaitWithoutAsyncMethod, "await __tagHelperRunner.RunAsync(__tagHelperExecutionContext)").WithArguments("System.Threading.Tasks.Task").WithLocation(142, 9),

‎src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/RazorSourceGeneratorTests.cs‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1429,14 +1429,7 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
14291429
var driver = await GetDriverAsync(project);
14301430

14311431
// Act
1432-
var result = RunGenerator(compilation!, ref driver,
1433-
// Microsoft.NET.Sdk.Razor.SourceGenerators/Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator/Pages_Index_cshtml.g.cs(68,167): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
1434-
// __tagHelperExecutionContext = __tagHelperScopeManager.Begin("email", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => {
1435-
Diagnostic(ErrorCode.WRN_AsyncLacksAwaits, "=>").WithLocation(68, 167),
1436-
// Microsoft.NET.Sdk.Razor.SourceGenerators/Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator/Pages_Index_cshtml.g.cs(84,171): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
1437-
// __tagHelperExecutionContext = __tagHelperScopeManager.Begin("email", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => {
1438-
Diagnostic(ErrorCode.WRN_AsyncLacksAwaits, "=>").WithLocation(84, 171)
1439-
);
1432+
var result = RunGenerator(compilation!, ref driver);
14401433

14411434
// Assert
14421435
Assert.Empty(result.Diagnostics);

‎src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/AutoInsert/AutoInsertService.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ internal class AutoInsertService(IEnumerable<IOnAutoInsertProvider> onAutoInsert
1818
public static FrozenSet<string> HtmlAllowedAutoInsertTriggerCharacters { get; }
1919
= new string[] { "=" }.ToFrozenSet(StringComparer.Ordinal);
2020
public static FrozenSet<string> CSharpAllowedAutoInsertTriggerCharacters { get; }
21-
= new string[] { "'", "/", "\n" }.ToFrozenSet(StringComparer.Ordinal);
21+
= new string[] { "'", "/", "\n", "\"" }.ToFrozenSet(StringComparer.Ordinal);
2222

2323
private readonly ImmutableArray<string> _triggerCharacters = CalculateTriggerCharacters(onAutoInsertProviders);
2424

‎src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/CodeActions/Razor/ExtractToComponentCodeActionResolver.cs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// Licensed to the .NET Foundation under one or more agreements.
22
// The .NET Foundation licenses this file to you under the MIT license.
33

4-
#if !NET
5-
using System;
6-
#endif
74
using System.IO;
85
using System.Text.Json;
96
using System.Threading;

0 commit comments

Comments
 (0)