Use Microsoft.IO over System.IO #9869
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When targeting .NET Framework, some commonly-used System.IO classes have worse performance than in .NET. They are also not null-annotated, which can allow bugs to slip through undetected. This change uses a global alias across the solution so that Path and Directory types come from the newer Microsoft.IO package/assembly. This gives us a reduction in allocations, access to newer methods (like Path.Join), and correct null annotations. All other changes here are in response to the user of the newer package, mostly around handling null values correctly.
drewnoakes
force-pushed
the
use-microsoft-io
branch
from
575b88d to
03c789e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When targeting .NET Framework, some commonly-used System.IO classes have worse performance than in .NET. They are also not null-annotated, which can allow bugs to slip through undetected.
This change uses a global alias across the solution so that Path and Directory types come from the newer Microsoft.IO package/assembly. This gives us a reduction in allocations, access to newer methods (like Path.Join), and correct null annotations.
All other changes here are in response to the user of the newer package, mostly around handling null values correctly.