Remove legacy resource editor

docs/repo/features.md

@@ -13,11 +13,6 @@ This repository contains the following broad features:
 ## Property Pages
 [Source](/src/Microsoft.VisualStudio.Editors/PropPages)
 
-## Resources Editor
-[Source](/src/Microsoft.VisualStudio.Editors/ResourceEditor)
-
-![Resources Editor](/docs/repo/images/resourceseditor.png?raw=true)
-
 ## Settings Designer
 [Source](/src/Microsoft.VisualStudio.Editors/SettingsDesigner)
 

docs/repo/getting-started.md

@@ -117,7 +117,7 @@ While the long term goal is to have all C#, F# and Visual Basic projects use thi
 4. In __File Explorer__, rename project from _[project].csproj_ -> _[project].msbuildproj_
 5. __File__ -> __Open__ -> __Project/Solution__ and browse to the project you just renamed and choose __Open__
 
-### AppDesigner, Settings, Resource Editors and Property Pages
+### AppDesigner, Settings and Property Pages
 Both the new project system and the existing project system use the features built from this repository.
 
 ## Code Coverage

src/Microsoft.VisualStudio.AppDesigner/ApplicationDesigner/ApplicationDesignerPanel.vb

@@ -53,7 +53,7 @@ Namespace Microsoft.VisualStudio.Editors.ApplicationDesigner
         Private _docCookie As UInteger
         Private _docData As Object
         'The DocView for the designer, if we were able to retrieve it (if we understood the designer type).  This would
-        '  be a PropPageDesignerView for our hosted property pages, ResourceEditorView for the resource editor, etc.
+        '  be a PropPageDesignerView for our hosted property pages, etc.
         Private _docView As Control
 
         'This is Nothing if we're not displaying a property page

src/Microsoft.VisualStudio.AppDesigner/ApplicationDesigner/ApplicationDesignerRootComponent.vb

@@ -24,7 +24,7 @@ Namespace Microsoft.VisualStudio.Editors.ApplicationDesigner
         '''   designer which is showing the UI to the user which allows this component's
         '''   resx file to be edited by the user.
         ''' </summary>
-        ''' <value>The associated ResourceEditorRootDesigner.</value>
+        ''' <value>The associated ApplicationDesignerRootDesigner.</value>
         Public ReadOnly Property RootDesigner As ApplicationDesignerRootDesigner
             Get
                 If _rootDesigner Is Nothing Then

src/Microsoft.VisualStudio.AppDesigner/ApplicationDesigner/ApplicationDesignerRootDesigner.vb

@@ -5,12 +5,8 @@ Imports System.ComponentModel.Design
 
 Namespace Microsoft.VisualStudio.Editors.ApplicationDesigner
 
-    ' {E18B7249-8322-44c3-9A57-FE5FF3889F89}
-    'static const GUID <<name>> = 
-    '{ 0xe18b7249, 0x8322, 0x44c3, { 0x9a, 0x57, 0xfe, 0x5f, 0xf3, 0x88, 0x9f, 0x89 } };
-
     ''' <summary>
-    ''' This is the designer for the top-level resource editor component (ApplicationDesigner).  I.e., this
+    ''' This is the designer for the top-level editor component (ApplicationDesigner).  I.e., this
     ''' is the top-level designer.  
     ''' </summary>
     Public NotInheritable Class ApplicationDesignerRootDesigner
@@ -69,7 +65,7 @@ Namespace Microsoft.VisualStudio.Editors.ApplicationDesigner
 
         ''' <summary>
         ''' Called by the managed designer mechanism to determine what kinds of view technologies we support.
-        ''' We currently support only Windows Forms technology (i.e., our designer view, ResourceEditorView,
+        ''' We currently support only Windows Forms technology (i.e., our designer view which
         ''' inherits from System.Windows.Forms.Control)
         ''' </summary>
         ''' <remarks>
@@ -83,11 +79,11 @@ Namespace Microsoft.VisualStudio.Editors.ApplicationDesigner
 
         ''' <summary>
         '''   Called by the managed designer technology to get our view, or the actual control that implements
-        '''   our resource editor's designer surface.  In this case, we return an instance of ResourceEditorView.
+        '''   our application designer surface.  In this case, we return an instance of ApplicationDesignerView.
         ''' </summary>
         ''' <param name="Technology"></param>
         ''' <remarks>
-        '''   The newly-instantiated ResourceEditorView object.
+        '''   The newly-instantiated ApplicationDesignerView object.
         ''' </remarks>
         Private Function RootDesigner_GetView(Technology As ViewTechnology) As Object Implements IRootDesigner.GetView
             If Technology <> ViewTechnology.Default Then

src/Microsoft.VisualStudio.AppDesigner/Common/Utils.vb

@@ -18,11 +18,6 @@ Namespace Microsoft.VisualStudio.Editors.AppDesCommon
 
     Friend Module Utils
 
-        'The transparent color used for all bitmaps in the resource editor is lime (R=0, G=255, B=0).
-        '  Any pixels of this color will be converted to transparent if StandardTransparentColor
-        '  is passed to GetManifestBitmap
-        Public ReadOnly StandardTransparentColor As Color = Color.Lime
-
         Public VBPackageInstance As IVBPackage
 
         ' The maximal amount of files that can be added at one shot. (copied from other VS features)
@@ -109,17 +104,6 @@ Namespace Microsoft.VisualStudio.Editors.AppDesCommon
             End If
         End Function
 
-        ''' <summary>
-        ''' Retrieves a transparent copy of a given bitmap from the manifest resources.
-        ''' </summary>
-        ''' <param name="BitmapID">Name of the bitmap resource (not including the assembly name, e.g. "Link.bmp")</param>
-        ''' <param name="assembly">Name of assembly containing the manifest resource</param>
-        ''' <returns>The retrieved transparent bitmap</returns>
-        ''' <remarks>Throws an internal exception if the bitmap cannot be found or loaded.</remarks>
-        Public Function GetManifestBitmapTransparent(BitmapID As String, Optional ByRef assembly As Assembly = Nothing) As Bitmap
-            Return GetManifestBitmapTransparent(BitmapID, StandardTransparentColor, assembly)
-        End Function
-
         ''' <summary>
         ''' Retrieves a given image from the manifest resources.
         ''' </summary>
@@ -299,22 +283,6 @@ Namespace Microsoft.VisualStudio.Editors.AppDesCommon
             End If
         End Sub
 
-        ''' <summary>
-        ''' Set the drop-down width of a datagridviewcomboboxcolumn wide enough to show the text of all entries in it
-        ''' </summary>
-        ''' <param name="column">The column to change the width for</param>
-        ''' <remarks>
-        ''' This does not take the current cell style into account - it uses the font from the parent datagridview (if any)
-        ''' It also makes room for the scrollbar even though it may not be visible...
-        ''' </remarks>
-        Public Sub SetComboBoxColumnDropdownWidth(column As DataGridViewComboBoxColumn)
-            If column IsNot Nothing AndAlso column.DataGridView IsNot Nothing Then
-                column.DropDownWidth = Math.Max(MeasureMaxTextWidth(column.DataGridView, column.Items) + SystemInformation.VerticalScrollBarWidth, column.Width)
-            Else
-                Debug.Fail("SetComboBoxColumnDropdownWidth: No combobox column specified, or the column didn't have a parent datagridview!")
-            End If
-        End Sub
-
         ''' <summary>
         ''' Check whether the screen reader is running
         ''' </summary>
@@ -331,29 +299,6 @@ Namespace Microsoft.VisualStudio.Editors.AppDesCommon
             Return False
         End Function
 
-        ''' <summary>
-        ''' Sets error code and error message through IVsUIShell interface
-        ''' </summary>
-        ''' <param name="hr">error code</param>
-        ''' <param name="errorMessage">error message</param>
-        Public Sub SetErrorInfo(sp As ServiceProvider, hr As Integer, errorMessage As String)
-            Dim vsUIShell As IVsUIShell = Nothing
-
-            If sp IsNot Nothing Then
-                vsUIShell = CType(sp.GetService(GetType(IVsUIShell)), IVsUIShell)
-            End If
-
-            If vsUIShell Is Nothing AndAlso Not VBPackageInstance IsNot Nothing Then
-                vsUIShell = CType(VBPackageInstance.GetService(GetType(IVsUIShell)), IVsUIShell)
-            End If
-
-            If vsUIShell IsNot Nothing Then
-                vsUIShell.SetErrorInfo(hr, errorMessage, 0, Nothing, Nothing)
-            Else
-                Debug.Fail("Could not get IVsUIShell from service provider. Can't set specific error message.")
-            End If
-        End Sub
-
         ''' <summary>
         ''' Sets focus to the first (or last) control inside of a parent HWND.
         ''' </summary>

src/Microsoft.VisualStudio.AppDesigner/Common/switches.vb

@@ -21,7 +21,7 @@ Namespace Microsoft.VisualStudio.Editors.AppDesCommon
         .
         .
         .
-        Public Shared FileWatcher As New TraceSwitch("FileWatcher", "Trace the resource editor FileWatcher class.")
+        Public Shared FileWatcher As New TraceSwitch("FileWatcher", "Trace the property page editor FileWatcher class.")
         .
         .
         .
@@ -145,48 +145,6 @@ Namespace Microsoft.VisualStudio.Editors.AppDesCommon
     ''' </summary>
     Friend NotInheritable Class Switches
 
-        '------------- Resource Editor -------------
-
-        ''' <summary>
-        ''' Trace for the ResourceEditor.FileWatcher class
-        ''' </summary>
-        Public Shared RSEFileWatcher As New TraceSwitch("RSEFileWatcher", "Trace the resource editor FileWatcher class.")
-
-        ''' <summary>
-        ''' Tracing for the ResourceEditor.ResourceSerializationService class
-        ''' </summary>
-        Public Shared RSEResourceSerializationService As New TraceSwitch("RSEResourceSerializationService", "Trace the resource editor ResourceSerializationService class.")
-
-        ''' <summary>
-        ''' Track adding and removing resources in the resource editor
-        ''' </summary>
-        Public Shared RSEAddRemoveResources As New TraceSwitch("RSEAddRemoveResources", "Trace adding/removing resources in the resource editor")
-
-        ''' <summary>
-        ''' Trace virtual mode methods in the resource editor's string table
-        ''' </summary>
-        Public Shared RSEVirtualStringTable As New TraceSwitch("RSEVirtualStringTable", "Trace virtual mode methods in the resource editor's string table")
-
-        ''' <summary>
-        ''' Trace virtual mode methods in the resource editor's listview
-        ''' </summary>
-        Public Shared RSEVirtualListView As New TraceSwitch("RSEVirtualListView", "Trace virtual mode methods in the resource editor's listview")
-
-        ''' <summary>
-        ''' Trace the delayed checking of errors in resources
-        ''' </summary>
-        Public Shared RSEDelayCheckErrors As New TraceSwitch("RSEDelayCheckErrors", "Trace the delayed checking of errors in resources")
-
-        ''' <summary>
-        ''' Disable high-quality options on the Graphics object when creating thumbnails in the resource editor
-        ''' </summary>
-        Public Shared RSEDisableHighQualityThumbnails As New BooleanSwitch("RSEDisableHighQualityThumbnails", "Disable high-quality options on the Graphics object when creating thumbnails in the resource editor")
-
-        ''' <summary>
-        ''' Trace find/replace in the resource editor
-        ''' </summary>
-        Public Shared RSEFindReplace As New TraceSwitch("RSEFindReplace", "Trace find/replace in the resource editor")
-
         '------------- Designer Framework -------------
 
         ''' <summary>
@@ -614,71 +572,6 @@ Namespace Microsoft.VisualStudio.Editors.AppDesCommon
 #End If
         End Sub
 
-        ''' <summary>
-        ''' Traces the access modifier combobox functionality
-        ''' </summary>
-        <Conditional("DEBUG")>
-        Public Shared Sub TracePDAccessModifierCombobox(traceLevel As TraceLevel, message As String)
-#If DEBUG Then
-            Trace.WriteLineIf(PDAccessModifierCombobox.Level >= traceLevel, "PDAccessModifierCombobox: " & message)
-#End If
-        End Sub
-
-        ''' <summary>
-        ''' Trace serialization of settings
-        ''' </summary>
-        ''' <param name="tracelevel"></param>
-        ''' <param name="message"></param>
-        <Conditional("DEBUG")>
-        Public Overloads Shared Sub TraceSDSerializeSettings(tracelevel As TraceLevel, message As String)
-#If DEBUG Then
-            Trace.WriteLineIf(SDSerializeSettings.Level >= tracelevel, message)
-#End If
-        End Sub
-
-        ''' <summary>
-        ''' Trace serialization of settings
-        ''' </summary>
-        ''' <param name="tracelevel"></param>
-        ''' <param name="formatString"></param>
-        ''' <param name="parameters"></param>
-        <Conditional("DEBUG")>
-        Public Overloads Shared Sub TraceSDSerializeSettings(tracelevel As TraceLevel, formatString As String, ParamArray parameters() As Object)
-#If DEBUG Then
-            Trace.WriteLineIf(SDSerializeSettings.Level >= tracelevel, String.Format(formatString, parameters))
-#End If
-        End Sub
-
-        <Conditional("DEBUG")>
-        Public Overloads Shared Sub TracePDLinqImports(tracelevel As TraceLevel, formatString As String, ParamArray parameters() As Object)
-#If DEBUG Then
-            Trace.WriteLineIf(PDLinqImports.Level >= tracelevel, Format(formatString, parameters))
-#End If
-        End Sub
-
-        ''' <summary>
-        ''' Trace changes to one of the monitored configuration files 
-        ''' </summary>
-        ''' <param name="tracelevel"></param>
-        <Conditional("DEBUG")>
-        Public Overloads Shared Sub TraceWCFConfigFileChangeWatch(tracelevel As TraceLevel, formatString As String, ParamArray parameters() As Object)
-#If DEBUG Then
-            Trace.WriteLineIf(WCF_Config_FileChangeWatch.Level >= tracelevel, String.Format(formatString, parameters))
-#End If
-        End Sub
-
-        ''' <summary>
-        ''' Trace changes to one of the monitored configuration files 
-        ''' </summary>
-        ''' <param name="tracelevel"></param>
-        ''' <param name="message"></param>
-        <Conditional("DEBUG")>
-        Public Overloads Shared Sub TraceWCFConfigFileChangeWatch(tracelevel As TraceLevel, message As String)
-#If DEBUG Then
-            Trace.WriteLineIf(WCF_Config_FileChangeWatch.Level >= tracelevel, message)
-#End If
-        End Sub
-
         <Conditional("DEBUG")>
         Public Shared Sub TracePDPerfBegin(e As System.Windows.Forms.LayoutEventArgs, Message As String, ParamArray FormatArguments() As Object)
 #If DEBUG Then
@@ -687,14 +580,6 @@ Namespace Microsoft.VisualStudio.Editors.AppDesCommon
 #End If
         End Sub
 
-        <Conditional("DEBUG")>
-        Public Shared Sub TraceMyExtensibility(traceLevel As TraceLevel, message As String)
-#If DEBUG Then
-            Trace.WriteLineIf(MyExtensibilityTraceSwitch.Level >= traceLevel, String.Format("MyExtensibility {0} {1}: ", Date.Now.ToLongDateString(), Date.Now.ToLongTimeString()))
-            Trace.WriteLineIf(MyExtensibilityTraceSwitch.Level >= traceLevel, message)
-#End If
-        End Sub
-
     End Class
 
 End Namespace

src/Microsoft.VisualStudio.AppDesigner/DesignerFramework/BaseRootDesigner.vb

@@ -82,8 +82,7 @@ Namespace Microsoft.VisualStudio.Editors.AppDesDesignerFramework
         '''  TRUE to keep previously registered menu commands for this designer.
         '''  FALSE otherwise, the root designer will clear its menu commands list and add the new one.
         ''' </param>
-        ''' <remarks>Child root designers call this method to register their own menu commands. 
-        '''      See ResourceEditorRootDesigner.</remarks>
+        ''' <remarks>Child root designers call this method to register their own menu commands.</remarks>
         Public Sub RegisterMenuCommands(MenuCommands As ArrayList,
                 Optional KeepRegisteredMenuCommands As Boolean = True)
             ' Clear the list of menu commands if specified.

src/Microsoft.VisualStudio.AppDesigner/PropPageDesigner/PropPageDesignerEditorFactory.vb

@@ -15,8 +15,8 @@ Namespace Microsoft.VisualStudio.Editors.PropPageDesigner
     ';PropPageDesignerEditorFactory
     '
     'Remarks:
-    '   The editor factory for the resource editor.  The job of this class is
-    '   simply to create a new resource editor designer when requested by the
+    '   The editor factory for the property page editor.  The job of this class is
+    '   simply to create a new property page editor designer when requested by the
     '   shell.
     '**************************************************************************
     <CLSCompliant(False),

src/Microsoft.VisualStudio.AppDesigner/PropPageDesigner/PropPageDesignerRootComponent.vb

@@ -31,7 +31,7 @@ Namespace Microsoft.VisualStudio.Editors.PropPageDesigner
         '''   designer which is showing the UI to the user which allows this component's
         '''   resx file to be edited by the user.
         ''' </summary>
-        ''' <value>The associated ResourceEditorRootDesigner.</value>
+        ''' <value>The associated PropPageDesignerRootDesigner.</value>
         Public ReadOnly Property RootDesigner As PropPageDesignerRootDesigner
             Get
                 If _rootDesigner Is Nothing Then

src/Microsoft.VisualStudio.AppDesigner/PropPageDesigner/PropPageDesignerRootDesigner.vb

@@ -4,12 +4,8 @@ Imports System.ComponentModel.Design
 
 Namespace Microsoft.VisualStudio.Editors.PropPageDesigner
 
-    ' {E18B7249-8322-44c3-9A57-FE5FF3889F89}
-    'static const GUID <<name>> = 
-    '{ 0xe18b7249, 0x8322, 0x44c3, { 0x9a, 0x57, 0xfe, 0x5f, 0xf3, 0x88, 0x9f, 0x89 } };
-
     ''' <summary>
-    ''' This is the designer for the top-level resource editor component (PropPageDesigner).  I.e., this
+    ''' This is the designer for the top-level property page editor component (PropPageDesigner).  I.e., this
     ''' is the top-level designer.  
     ''' </summary>
     Public NotInheritable Class PropPageDesignerRootDesigner
@@ -45,7 +41,7 @@ Namespace Microsoft.VisualStudio.Editors.PropPageDesigner
 
         ''' <summary>
         ''' Called by the managed designer mechanism to determine what kinds of view technologies we support.
-        ''' We currently support only Windows Forms technology (i.e., our designer view, ResourceEditorView,
+        ''' We currently support only Windows Forms technology (i.e., our designer view which
         ''' inherits from System.Windows.Forms.Control)
         ''' </summary>
         ''' <remarks>
@@ -59,11 +55,11 @@ Namespace Microsoft.VisualStudio.Editors.PropPageDesigner
 
         ''' <summary>
         '''   Called by the managed designer technology to get our view, or the actual control that implements
-        '''   our resource editor's designer surface.  In this case, we return an instance of ResourceEditorView.
+        '''   our property page editor's designer surface.  In this case, we return an instance of PropPageDesignerView.
         ''' </summary>
         ''' <param name="Technology"></param>
         ''' <remarks>
-        '''   The newly-instantiated ResourceEditorView object.
+        '''   The newly-instantiated PropPageDesignerView object.
         ''' </remarks>
         Private Function RootDesigner_GetView(Technology As ViewTechnology) As Object Implements IRootDesigner.GetView
             If Technology <> ViewTechnology.Default Then

src/Microsoft.VisualStudio.AppDesigner/PropPageDesigner/PropertyPageSerializationService.vb

@@ -131,7 +131,7 @@ Namespace Microsoft.VisualStudio.Editors.PropPageDesigner
         Public Overrides Sub SerializeMemberAbsolute(Store As SerializationStore, OwningObject As Object, Member As MemberDescriptor)
             'This method is intended for properties such as collections which might have had only some of their
             '  members changed.
-            'The resource editor doesn't have any such properties, so we just treat this the same
+            'The property page editor doesn't have any such properties, so we just treat this the same
             '  as simple SerializeMember (ignoring OldValue)
 
             SerializeMember(Store, OwningObject, Member)