Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Add EnumDisplaySettings #510

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

weitzhandler
Copy link
Contributor

@weitzhandler weitzhandler commented Jul 13, 2020

This PR adds two functions and their underlying types:

There must be a problem, probably fixable easily, but the test I added here doesn't pass.

@AArnott can you please and have a look and/or checkout my branch?

@weitzhandler weitzhandler marked this pull request as draft July 13, 2020 05:42
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @weitzhandler! This looks like a lot of work and including the test was a great way to identify the bug in the field offsets.

src/User32/User32.cs Outdated Show resolved Hide resolved
src/Windows.Core/DEVMODEW.cs Outdated Show resolved Hide resolved
src/Windows.Core/DEVMODEW.cs Outdated Show resolved Hide resolved
src/Windows.Core/DEVMODEW.cs Outdated Show resolved Hide resolved
src/Windows.Core/DEVMODEW.cs Outdated Show resolved Hide resolved
src/Windows.Core/DEVMODEW.cs Outdated Show resolved Hide resolved
src/Windows.Core/POINT.cs Outdated Show resolved Hide resolved
@weitzhandler weitzhandler force-pushed the feature/additional-functions branch from 9ec5e24 to 9e3930d Compare July 14, 2020 16:16
@weitzhandler weitzhandler marked this pull request as ready for review July 14, 2020 16:16
Copy link
Member

@vatsan-madhavan vatsan-madhavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/Windows.Core/DEVMODE.cs Outdated Show resolved Hide resolved
src/Windows.Core/DEVMODE.cs Outdated Show resolved Hide resolved
src/Windows.Core/DEVMODE.cs Outdated Show resolved Hide resolved
src/Windows.Core/DEVMODE.cs Outdated Show resolved Hide resolved
@weitzhandler weitzhandler force-pushed the feature/additional-functions branch from 9e3930d to cf8f33a Compare July 14, 2020 17:04
@weitzhandler weitzhandler requested a review from AArnott July 14, 2020 17:08
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. We could take it as-is. But if you don't mind humoring me a bit as we negotiate the patterns for nested types (either in discussion or applying my suggested changes), I'd like to explore that option first.

src/User32/User32+EnumDisplaySettingsExFlags.cs Outdated Show resolved Hide resolved
src/User32/User32.cs Outdated Show resolved Hide resolved
src/Windows.Core/DEVMODE.cs Outdated Show resolved Hide resolved
weitzhandler added a commit to weitzhandler/pinvoke that referenced this pull request Jul 17, 2020
@weitzhandler
Copy link
Contributor Author

I'd like to explore that option first

So I added it as a separate commit, so we can roll back if you don't like it.

@weitzhandler weitzhandler force-pushed the feature/additional-functions branch from 540c495 to a2127ca Compare July 17, 2020 11:29
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott AArnott merged commit cc67461 into dotnet:master Jul 17, 2020
@weitzhandler weitzhandler deleted the feature/additional-functions branch July 17, 2020 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants