-
-
Notifications
You must be signed in to change notification settings - Fork 223
Add EnumDisplaySettings #510
Add EnumDisplaySettings #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @weitzhandler! This looks like a lot of work and including the test was a great way to identify the bug in the field offsets.
9ec5e24
to
9e3930d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
9e3930d
to
cf8f33a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. We could take it as-is. But if you don't mind humoring me a bit as we negotiate the patterns for nested types (either in discussion or applying my suggested changes), I'd like to explore that option first.
So I added it as a separate commit, so we can roll back if you don't like it. |
540c495
to
a2127ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds two functions and their underlying types:
EnumDisplaySettings
EnumDisplaySettingsEx
DEVMODE
There must be a problem, probably fixable easily, but the test I added here doesn't pass.
@AArnott can you please and have a look and/or checkout my branch?