Add kernel32!SetHandleInformation and kernel32!GetHandleInformation

[mckunda]

• P/Invokes for kernel32!SetHandleInformation and kernel32!GetHandleInformation
• HandleFlags enum

[mckunda]

@AArnott if you have any ideas on how to test these, please let me know

[AArnott]

Thanks for your contribution. You've obviously taken care t
Thank you for your contribution! You obviously were careful to conform to our conventions and I appreciate it.

I've called out some changes to be made, then we'll be happy to merge.

[AArnott]

The [In] is not ordinarily necessary. Unless there's some reason you had to add it, please remove.

[AArnott]

Please remove [In] and [Out] here as well. The out modifier as well should be removed since this isn't a pointer to a pointer. It's just a pointer that we must pass in so that Win32 knows where to write the DWORD. I'm pretty sure this would fail as written here.

Also please add [Friendly(FriendlyFlags.Out)] to the HandleFlags* parameter so that an overload is generated that has an out HandleFlags parameter.

[AArnott]

Regarding how to test this (which seems like a good idea), you could create a ManualResetEvent in the unit test and then obtain its Handle property, and call the 2 new methods on that handle, just to see if no exception is thrown.

[mckunda]

Thanks for the feedback! Hope I understood you correctly. Also, I'd like to point out two things:

1. Is it okay that from GetHandleInformation we may get a result that's not defined in HandleFlags, e.g. 0x00000003, which is HANDLE_FLAG_INHERIT | HANDLE_FLAG_PROTECT_FROM_CLOSE? Honestly, I don't quite understand that.
2. Also I don't know if the methods I added are store-banned, because I have no clue how to check that. Could you please explain?

[AArnott]

Looks great. Can you touch up the test methods slightly?

[AArnott]

You can check for store-banned status from the Microsoft API docs for the method:

So that's a good point: we need to move these methods to the storebanned folder so they don't cause store app rejection.

[AArnott]

Is it okay that from GetHandleInformation we may get a result that's not defined in HandleFlags

Yes: that's the nature of [Flags] enums. Folks would test for individual flags.

[AArnott]

Please move to store banned folder.

[mckunda]

Thanks for the help! Hope now it's all OK.

[AArnott]

Thanks!