Use net8.0 for Maui tests until Maui is ready for net9.0#3437
Conversation
…aui is ready for net9.0.
|
In the public App()
{
InitializeComponent();
MainPage = new MainPage();
// Startup event
var activity = MainActivity.Context as Activity;
activity.ReportFullyDrawn();
} |
|
If you want to all Something like But for a MAUI+Blazor app, you want to call it after all HTML content has fully loaded? |
|
Yea, after the html is all loaded is the goal. Before we were calling the report fully drawn in "protected override void OnAfterRender(bool firstRender)", is there a good way to figure out if this is still available? It used to be put in the file "app/Pages/Index.razor.cs". |
|
@Eilon @mkArtakMSFT did the |
|
I did some testing and think I found where to move the OnAfterRender(). I am working on trying to fix some other pipeline things before pushing here. |
This reverts commit bc47f6f.
|
| with open(f"{const.APPDIR}/Pages/Index.razor.cs", "w") as indexCSFile: | ||
| indexCSFile.write(''' | ||
| using Microsoft.AspNetCore.Components; | ||
| #if ANDROID | ||
| using Android.App; | ||
| #endif\n\n''' | ||
| + f" namespace {EXENAME}.Pages" + | ||
| # Update the home.razor file with the code | ||
| with open(f"{const.APPDIR}/Components/Pages/Home.razor", "a") as homeRazorFile: | ||
| homeRazorFile.write( |
There was a problem hiding this comment.
So, this broke because we reworked the template?
@Eilon do you think these files would move around often?
@LoopedBard3 could this error immediately if this file goes missing?
There was a problem hiding this comment.
Yes, the template app changed along with the file structure. If there is another major change, we should see a similar build error if the Home.razor file is removed or renamed.
There was a problem hiding this comment.
@Eilon do you think these files would move around often?
No, this was the big template update for .NET 8, and no plans to make any significant changes until GA.
Use 8.0 channel and net8.0 dotnet version link for Maui tests until Maui is ready for net9.0. This fixes the ci_setup.py error:
RuntimeError: Unable to determine the .NET SDK used for net9.0Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2299328&view=results
Note: The default maui blazor app has also updated, breaking those builds. Will fix in another PR, this PR fixes the ci_setup issue.
@kotlarmilos @jonathanpeppers, do either of you know the current best contact for the performance of the maui-blazor app? The new default is going to impact the results of the performance testing and require a new insertion point for when we call activity.ReportFullyDrawn(), etc.