Update BDN version #3331
Merged
Update BDN version #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrewScoggins
force-pushed
the
UpdateBDNSept
branch
from
abc9648 to
8c606f1
Compare
cincuranet
approved these changes
Sep 13, 2023
2 tasks
radical
added a commit
to radical/performance
that referenced
this pull request
Sep 14, 2023
`dotnet/performance` got an update for `dotnet/BenchmarkDotNet` via dotnet#3331 . And that bdn update includes dotnet/BenchmarkDotNet#2375, which subtly changes how the arguments get parsed, and breaks the existing scripts: ``` $ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks" $ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ... MicroBenchmarks 1.0.0-dev © Microsoft Corporation. All rights reserved. ERROR(S): Option 'experimental-wasm-eh --expose_wasm --module' is unknown. ``` Related: dotnet/runtime#92066 .
radical
added a commit
to radical/runtime
that referenced
this pull request
Sep 14, 2023
`dotnet/performance` got an update for `dotnet/BenchmarkDotNet` via dotnet/performance#3331 . And that bdn update includes dotnet/BenchmarkDotNet#2375, which subtly changes how the arguments get parsed, and breaks the existing scripts: ``` $ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks" $ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ... MicroBenchmarks 1.0.0-dev © Microsoft Corporation. All rights reserved. ERROR(S): Option 'experimental-wasm-eh --expose_wasm --module' is unknown. ``` Fixes dotnet#92066 .
This was referenced Sep 14, 2023
cincuranet
pushed a commit
that referenced
this pull request
Sep 14, 2023
* [wasm] Fix scripts to track change in BDN `dotnet/performance` got an update for `dotnet/BenchmarkDotNet` via #3331 . And that bdn update includes dotnet/BenchmarkDotNet#2375, which subtly changes how the arguments get parsed, and breaks the existing scripts: ``` $ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks" $ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ... MicroBenchmarks 1.0.0-dev © Microsoft Corporation. All rights reserved. ERROR(S): Option 'experimental-wasm-eh --expose_wasm --module' is unknown. ``` Related: dotnet/runtime#92066 . * address feedback, and add comments
radical
added a commit
to dotnet/runtime
that referenced
this pull request
Sep 14, 2023
* [wasm] Fix performance-setup.sh to track change in BDN `dotnet/performance` got an update for `dotnet/BenchmarkDotNet` via dotnet/performance#3331 . And that bdn update includes dotnet/BenchmarkDotNet#2375, which subtly changes how the arguments get parsed, and breaks the existing scripts: ``` $ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks" $ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ... MicroBenchmarks 1.0.0-dev © Microsoft Corporation. All rights reserved. ERROR(S): Option 'experimental-wasm-eh --expose_wasm --module' is unknown. ``` Fixes #92066 . * fix command line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the BDN version to include this fix, https://github.com/dotnet/BenchmarkDotNet/pull/2375/files. This resolves an issue with filtering that was happening with the GC performance tests.