-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update centos7 image to net image #3004
Update centos7 image to net image #3004
Conversation
This reverts commit 064acfb.
…Bard3/performance into SwitchFromCentosToMariner
…erged, and centos7 is no longer supported.
@adamsitnik CentOS appears to have been chosen as a part of #2328. I am wondering if you are aware of any specific reasons CentOS was chosen over other containers, such as the ubuntu one this would change the run to? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although we should probably notify interested parties for possible changes in numbers from the OS change.
TBH I did not remember the reason, but from the list of my commits of shame where I was trying to get it working I can see that it just had all native dependencies in place: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @LoopedBard3 !
afaik this CI leg was used only for verification that all benchmarks can be compiler and executed for NativeAOT. |
I'll merge it to unblock other PRs |
Centos is not being supported in net8 because it doesn't have up to date GLIBCXX files. Initial issue figuring this out: dotnet/sdk#31893, additional information: dotnet/runtime#83428