[Release/7.0] Add Maui Mobile Android Benchmarks #2789
Conversation
…blish for pre.py.
…rently connected to windows.
… it is." This reverts commit 3ab14c6.
…of github API to get the commit date.
…nly transferring one file.
…cted size sod testing by adding precommands to extract the apk zip.
… sure to delete it if it exists.
src/scenarios/mauiandroid/pre.py
Outdated
|
|
||
| # Download what we need | ||
| with open ("MauiNuGet.config", "wb") as f: | ||
| f.write(requests.get(f'https://raw.githubusercontent.com/dotnet/maui/net7.0/NuGet.config', allow_redirects=True).content) |
There was a problem hiding this comment.
I suppose this will get (forward)ported to main eventually and hence the net7.0 here (and below) should come from variable.
| with open ("MauiNuGet.config", "wb") as f: | ||
| f.write(requests.get(f'https://raw.githubusercontent.com/dotnet/maui/net7.0/NuGet.config', allow_redirects=True).content) | ||
|
|
||
| subprocess.run(['git', 'clone', 'https://github.com/microsoft/dotnet-podcasts.git', '-b', 'net7.0', '--single-branch', '--depth', '1']) |
There was a problem hiding this comment.
Did you considered using submodule?
There was a problem hiding this comment.
I had not, but looking into submodules more, I think that the submodule commands would be overdoing what we need and come with additional cost of either merging the submodule each time the podcast app updates or having to call git multiple times to add and then init the submodule. However, since I have not used it much before I may just be misunderstanding the docs.
There was a problem hiding this comment.
You can track tip of branch with submodule. But my comment was purely question. I don't think either is superior solution and both work for me.
| os.remove(f"{output_file_partial_path}.aab") | ||
|
|
||
| # Copy the MauiVersion to a file so we have it on the machine | ||
| result = subprocess.run(['powershell', '-Command', rf'Get-ChildItem .\{const.APPDIR}\obj\Release\net7.0-android\android-arm64\linked\Microsoft.Maui.dll | Select-Object -ExpandProperty VersionInfo | Select-Object ProductVersion | Select-Object -ExpandProperty ProductVersion'], stdout=subprocess.PIPE, stderr=subprocess.STDOUT, shell=True) |
There was a problem hiding this comment.
I agree. And even parts of Python code are duplicated in pre.py/test.py. This could be refactored, once in final stretch, to separate files.
…otnet.py get commit date.
…ment capabilties.
LoopedBard3
force-pushed
the
AddMauiMobileTesting
branch
from
8f346e3 to
2cfb5fe
Compare
…nd setup the current maui android scenarios to use the non-special case.
…can be used to get values from any Dll on systems with powershell support.
LoopedBard3
force-pushed
the
AddMauiMobileTesting
branch
from
5e8a970 to
b13d06a
Compare
|
Working test run since this only runs on private builds: https://dev.azure.com/dnceng/internal/_build/results?buildId=2068946&view=results |
LoopedBard3
force-pushed
the
AddMauiMobileTesting
branch
from
802016c to
d0375ac
Compare
LoopedBard3
force-pushed
the
AddMauiMobileTesting
branch
from
d0375ac to
966861d
Compare
|
Successful test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2095104&view=results |
|
Errors are unrelated to these changes, merging. |
3 participants
This adds Maui Mobile scenarios for android, including android default, android podcast app, and blazor android. This also updates how the dotnet version commit date is retrieved to minimize throttling from running in public pools.