Skip to content

Fix RedisGrainDirectory uninitialize exception #9940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miguelhasse wants to merge 3 commits into from
Closed

Fix RedisGrainDirectory uninitialize exception #9940

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dfdefc
Refactor Redis disposal to use DisposeAsync with cleanup
miguelhasse Feb 18, 2026
0fdc3a6
Unsubscribe Redis event handlers on uninitialize
miguelhasse Feb 18, 2026
0842b8f
Merge branch 'main' into fix/redis-grain-directory-uninitialize-excep…
miguelhasse Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/Redis/Orleans.GrainDirectory.Redis/RedisGrainDirectory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,15 @@ private async Task Uninitialize(CancellationToken arg)
{
_disposed = true;

await _redis.CloseAsync();
_redis.Dispose();
_redis = null!;
_database = null!;
try
{
await _redis.DisposeAsync();
}
Comment thread
miguelhasse marked this conversation as resolved.
Outdated
finally
{
_redis = null!;
_database = null!;
}
Comment thread
miguelhasse marked this conversation as resolved.
Comment on lines +192 to +211

Copilot AI Feb 18, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change targets a shutdown-time exception path, but there’s no coverage ensuring Uninitialize is safe to call when initialization is partial/failed or when it’s invoked multiple times. Consider adding a Redis grain directory test which exercises the shutdown path (e.g., invoke Uninitialize via reflection or lifecycle and assert it doesn’t throw).

Copilot uses AI. Check for mistakes.
}
}

Expand Down
Loading