Skip to content

Fix flaky stuck grain forwarding test#9936

Merged
ReubenBond merged 1 commit into
dotnet:mainfrom
ReubenBond:copilot/fix-stuck-grain-forward-flaky-20260217
Feb 17, 2026
Merged

Fix flaky stuck grain forwarding test#9936
ReubenBond merged 1 commit into
dotnet:mainfrom
ReubenBond:copilot/fix-stuck-grain-forward-flaky-20260217

Conversation

@ReubenBond

@ReubenBond ReubenBond commented Feb 17, 2026

Copy link
Copy Markdown
Member

Summary

  • make StuckGrainTest_StuckDetectionAndForward deterministic by tracking the three queued NonBlockingCall() tasks
  • await completion of those forwarded calls directly instead of polling GetNonBlockingCallCounter()
  • keep the existing test flow and timing assumptions otherwise unchanged

Testing

  • dotnet test .\test\TesterInternal\TesterInternal.csproj --filter "FullyQualifiedName~StuckGrainTest_StuckDetectionAndForward" (repeated runs)
  • dotnet test .\test\TesterInternal\TesterInternal.csproj --filter "FullyQualifiedName~UnitTests.StuckGrainTests.StuckGrainTests" --no-build -v quiet
Microsoft Reviewers: Open in CodeFlow

Track the queued NonBlockingCall tasks and await their completion instead of polling GetNonBlockingCallCounter, which can observe a reset counter after activation forwarding.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 17, 2026 14:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ReubenBond ReubenBond added this pull request to the merge queue Feb 17, 2026
Merged via the queue into dotnet:main with commit 09728ff Feb 17, 2026
64 of 65 checks passed
@ReubenBond ReubenBond deleted the copilot/fix-stuck-grain-forward-flaky-20260217 branch February 17, 2026 16:21
rkargMsft pushed a commit to rkargMsft/orleans that referenced this pull request Feb 27, 2026
Track the queued NonBlockingCall tasks and await their completion instead of polling GetNonBlockingCallCounter, which can observe a reset counter after activation forwarding.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants