Fix flaky ObservableGrain_AsyncEnumerable_SlowConsumer test#9935
Merged
ReubenBond merged 1 commit intoFeb 17, 2026
Merged
Conversation
Capture cleanup count before each MoveNext cycle in ObservableGrain_AsyncEnumerable_SlowConsumer to avoid timer-alignment races that can wait an extra cleanup cycle and trigger enumerator eviction. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses flakiness in the ObservableGrain_AsyncEnumerable_SlowConsumer test by removing a timing race around when the cleanup-cycle counter is sampled relative to each MoveNext iteration.
Changes:
- Capture
CleanupCountbefore eachMoveNextiteration and use it to gate the “wait one cleanup cycle” delay. - Avoid accidental waiting for an extra cleanup cycle when cleanup completes immediately after
MoveNext.
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
) Fix flaky slow-consumer async enumerable test Capture cleanup count before each MoveNext cycle in ObservableGrain_AsyncEnumerable_SlowConsumer to avoid timer-alignment races that can wait an extra cleanup cycle and trigger enumerator eviction. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Microsoft Reviewers: Open in CodeFlow