Skip to content

Fix flaky GrainTimer_Change timer assertion timing #9928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 1 commit into from
Feb 16, 2026
Merged

Fix flaky GrainTimer_Change timer assertion timing #9928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions test/DefaultCluster.Tests/TimerOrleansTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,17 @@ public async Task GrainTimer_Change()

var grain3 = GrainFactory.GetGrain<ITimerCallGrain>(GetRandomGrainId());
await grain3.StartTimer(testName, delay, "dispose_timer");
await Task.Delay(wait);
var grain3Timeout = wait.Multiply(2);
var grain3Stopwatch = Stopwatch.StartNew();
var grain3TickCount = await grain3.GetTickCount();
while (grain3Stopwatch.Elapsed < grain3Timeout && grain3TickCount < 1)
{
await Task.Delay(TimeSpan.FromMilliseconds(200));
grain3TickCount = await grain3.GetTickCount();
}

Assert.Null(await grain3.GetException()); // Should be no exceptions during timer callback
Assert.Equal(1, await grain3.GetTickCount());
Assert.Equal(1, grain3TickCount);

await grain.StopTimer(testName);
}
Expand Down
Loading