Fix flaky NonReentrantGrainTimer_NoKeepAlive_Test#9925
Merged
ReubenBond merged 1 commit intoFeb 16, 2026
Conversation
Use a 30-second timer due time in the no-keepalive activation collector test so the timer does not fire before collection, matching the test intent and removing timing race. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky test (NonReentrantGrainTimer_NoKeepAlive_Test) that was experiencing race condition issues due to incorrect timer scheduling. The test verifies that a timer with keepAlive=false does not prevent grain deactivation during idle collection.
Changes:
- Changed the timer due time from 4 seconds to 30 seconds in the
NonReentrantGrainTimer_NoKeepAlive_Testto ensure the timer cannot fire before the grain is collected
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
Use a 30-second timer due time in the no-keepalive activation collector test so the timer does not fire before collection, matching the test intent and removing timing race. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Microsoft Reviewers: Open in CodeFlow