Fix dashboard log stream loading feedback when disabled#9922
Merged
Conversation
Enhanced error handling in log-stream.tsx to display detailed messages on 403 responses. Updated /Trace endpoint to return descriptive problem details when disabled, instead of a plain 403 status.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error feedback for the dashboard's log stream feature when the trace endpoint is disabled. Instead of returning a plain 403 status code, the backend now returns a structured Problem Details response with a descriptive error message. The frontend is updated to parse and display this error message.
Changes:
- Backend: Modified /Trace endpoint to return Results.Problem with descriptive error message when HideTrace is enabled
- Frontend: Updated log-stream component to parse JSON from 403 responses and extract the error detail message
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ServiceCollectionExtensions.cs | Changed /Trace endpoint to return structured Problem Details response instead of plain 403 when trace is disabled |
| log-stream.tsx | Added logic to parse 403 responses as JSON and display the error detail message |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
* Improve error feedback for log stream and trace endpoint Enhanced error handling in log-stream.tsx to display detailed messages on 403 responses. Updated /Trace endpoint to return descriptive problem details when disabled, instead of a plain 403 status. * Handle log stream 403 responses safely Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Reuben Bond <reuben.bond@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error feedback for log stream and trace endpoint
Enhanced error handling in log-stream.tsx to display detailed messages on 403 responses. Updated /Trace endpoint to return descriptive problem details when disabled, instead of a plain 403 status.
Microsoft Reviewers: Open in CodeFlow