Fix flaky ResumeAfterSlowSubscriber on slow machines#9918
Merged
ReubenBond merged 1 commit intoFeb 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky test by replacing fixed-time delays with timeout-backed polling assertions. The test ResumeAfterSlowSubscriber was failing intermittently on slow machines because it used 500ms Task.Delay calls that were insufficient for the assertions to pass reliably.
Changes:
- Replaced two
Task.Delay(500)+ immediate assertion patterns withTestingUtils.WaitUntilAsyncpolling - Added a local async helper function
CheckFastCounterthat implements the polling predicate with assertion on final try - Added
using Orleans.TestingHost.Utilsimport for TestingUtils access
Replace fixed 500ms delays with TestingUtils.WaitUntilAsync eventual assertions so slow machines do not fail before stream delivery completes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
force-pushed
the
copilot/fix-resume-slow-subscriber-flake-20260215-054753
branch
from
cc8818f to
a77a1a0
Compare
ReubenBond
deleted the
copilot/fix-resume-slow-subscriber-flake-20260215-054753
branch
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
Fix flaky ResumeAfterSlowSubscriber test Replace fixed 500ms delays with TestingUtils.WaitUntilAsync eventual assertions so slow machines do not fail before stream delivery completes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Microsoft Reviewers: Open in CodeFlow