Fix flaky StuckGrain forwarding test#9917
Merged
ReubenBond merged 1 commit intoFeb 15, 2026
Merged
Conversation
Stabilize StuckGrainTest_StuckDetectionAndForward by avoiding a brittle per-call timeout expectation and asserting eventual forwarded-call count with TestingUtils.WaitUntilAsync. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes a flaky stuck grain forwarding test by removing timing-dependent assertions and using polling for the final verification.
Changes:
- Replaced
Assert.ThrowsAsync<TimeoutException>for 3 non-blocking calls withTask.WhenAnyracing against a delay - Changed immediate counter assertion to use
TestingUtils.WaitUntilAsyncwith 10-second timeout and 200ms polling interval - Added
using Orleans.TestingHost.Utilsimport
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
Stabilize StuckGrainTest_StuckDetectionAndForward by avoiding a brittle per-call timeout expectation and asserting eventual forwarded-call count with TestingUtils.WaitUntilAsync. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Microsoft Reviewers: Open in CodeFlow