Skip to content

Fix flakiness in CallChainReentrancy_WithSuppression #9913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 1 commit into from
Feb 13, 2026
Merged

Fix flakiness in CallChainReentrancy_WithSuppression #9913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/Grains/TestGrains/DeadlockGrain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public class CallChainReentrancyGrain : Grain, ICallChainReentrancyGrain
public async Task CallChain(ICallChainObserver observer, List<(string TargetGrain, ReentrancyCallType CallType)> callChain, int callIndex, CancellationToken cancellationToken = default)
{
cancellationToken.ThrowIfCancellationRequested();
var unblocker = _unblocker;
await observer.OnEnter(Id, callIndex);
try
{
Expand All @@ -100,19 +101,19 @@ public async Task CallChain(ICallChainObserver observer, List<(string TargetGrai
switch (op.CallType)
{
case ReentrancyCallType.Regular:
await Task.WhenAny(_unblocker.Task, target.CallChain(observer, newChain, nextCallIndex, cancellationToken));
await Task.WhenAny(unblocker.Task, target.CallChain(observer, newChain, nextCallIndex, cancellationToken));
break;
case ReentrancyCallType.AllowCallChainReentrancy:
{
using var _ = RequestContext.AllowCallChainReentrancy();
await Task.WhenAny(_unblocker.Task, target.CallChain(observer, newChain, nextCallIndex, cancellationToken));
await Task.WhenAny(unblocker.Task, target.CallChain(observer, newChain, nextCallIndex, cancellationToken));
break;
}

case ReentrancyCallType.SuppressCallChainReentrancy:
{
using var _ = RequestContext.SuppressCallChainReentrancy();
await Task.WhenAny(_unblocker.Task, target.CallChain(observer, newChain, nextCallIndex, cancellationToken));
await Task.WhenAny(unblocker.Task, target.CallChain(observer, newChain, nextCallIndex, cancellationToken));
break;
}
}
Expand Down
Loading