Skip to content

Remove JSON format option from ADO.NET configuration docs#9836

Merged
ReubenBond merged 3 commits into
dotnet:mainfrom
alesma:patch-1
Feb 15, 2026
Merged

Remove JSON format option from ADO.NET configuration docs#9836
ReubenBond merged 3 commits into
dotnet:mainfrom
alesma:patch-1

Conversation

@alesma

@alesma alesma commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Removed the option to use JSON format for storage.

This option was removed in

316ddd7

Microsoft Reviewers: Open in CodeFlow

Copilot AI review requested due to automatic review settings December 9, 2025 08:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an outdated configuration option from the ADO.NET persistence documentation. The UseJsonFormat option was previously removed from the codebase in commit 316ddd7, but the documentation example was not updated at that time.

  • Removes the UseJsonFormat configuration line from the README example

@ReubenBond

Copy link
Copy Markdown
Member

@benjaminpetit ptal

@ranma42

ranma42 commented Dec 11, 2025

Copy link
Copy Markdown

A similar leftover (in the documentation) is here:

/// Optional configuration params:
/// <c>AdoInvariant</c> -- defaults to <c>Microsoft.Data.SqlClient</c>
/// <c>UseJsonFormat</c> -- defaults to <c>false</c>
/// <c>UseXmlFormat</c> -- defaults to <c>false</c>
/// <c>UseBinaryFormat</c> -- defaults to <c>true</c>
/// </para>

@alesma

alesma commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

Removed the option to use JSON format for storage.

This option was removed in 

dotnet@316ddd7
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ReubenBond ReubenBond changed the title Remove JSON format option from ADO.NET configuration Remove JSON format option from ADO.NET configuration docs Feb 15, 2026
@ReubenBond ReubenBond enabled auto-merge February 15, 2026 14:38
@ReubenBond ReubenBond added this pull request to the merge queue Feb 15, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Feb 15, 2026
* Remove JSON format option from ADO.NET configuration

Removed the option to use JSON format for storage.

This option was removed in 

316ddd7

* update AdoNetGrainStorage summary

* Fix ADO.NET invariant default in AdoNetGrainStorage docs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Reuben Bond <reuben.bond@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Merged via the queue into dotnet:main with commit 9a28428 Feb 15, 2026
56 of 59 checks passed
rkargMsft pushed a commit to rkargMsft/orleans that referenced this pull request Feb 27, 2026
* Remove JSON format option from ADO.NET configuration

Removed the option to use JSON format for storage.

This option was removed in 

dotnet@316ddd7

* update AdoNetGrainStorage summary

* Fix ADO.NET invariant default in AdoNetGrainStorage docs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Reuben Bond <reuben.bond@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants