Skip to content

[FIX] Dispose StatelessWorkerGrainContext when it contains no more workers #9636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 3 commits into from
Aug 28, 2025
Merged

[FIX] Dispose StatelessWorkerGrainContext when it contains no more workers #9636

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2be6566
ensure disposal is called when no workers are alive
ledjon-behluli Aug 4, 2025
a078007
hook continuation in order to log any erros that might occur during d…
ledjon-behluli Aug 4, 2025
8ae48d5
fully align SW context behavior based on if idle worker removal shoul…
ledjon-behluli Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ private async Task RunMessageLoop()
// When the last worker is destroyed, we can consider the stateless worker grain
// activation to be destroyed as well
_shared.InternalRuntime.Catalog.UnregisterMessageTarget(this);
var completion = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
EnqueueWorkItem(WorkItemType.DisposeAsync, new DisposeAsyncWorkItemState(completion));

Copilot AI Aug 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The completion variable is created but never used or awaited. Consider either using this TaskCompletionSource to wait for disposal completion or removing it if not needed.

Suggested change
var completion = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
EnqueueWorkItem(WorkItemType.DisposeAsync, new DisposeAsyncWorkItemState(completion));
EnqueueWorkItem(WorkItemType.DisposeAsync, new DisposeAsyncWorkItemState(null));

Copilot uses AI. Check for mistakes.

@ledjon-behluli ledjon-behluli Aug 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither is correct, for one the DisposeAsyncWorkItemState expects a non-null TCS, and awaiting the tcs.Task would deadlock the loop. Eitherway I hooked a continuation to at least log any potential errors that might occur in the dispose internal method.

}
break;
}
Expand Down
Loading