Skip to content

Conversation

@DeagleGross
Copy link
Member

@DeagleGross DeagleGross commented May 27, 2025

Spotted copilot doing changes to global.json in #9515 (comment), so adding a special copilot instructions file to manage behavior.

Copy & pasted most of it from aspnetcore

Microsoft Reviewers: Open in CodeFlow

@DeagleGross DeagleGross self-assigned this May 27, 2025
@ReubenBond ReubenBond requested a review from Copilot May 27, 2025 14:54
@ReubenBond ReubenBond merged commit 22a1b35 into main May 27, 2025
58 of 62 checks passed
@ReubenBond ReubenBond deleted the dmkorolev/copilot-instructions branch May 27, 2025 14:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new Copilot instructions file to centralize guidelines for AI-assisted code reviews and maintain consistent project style.

  • Introduces .github/copilot-instructions.md with general Copilot behavior rules.
  • Defines formatting, nullable reference, and testing guidelines.
Comments suppressed due to low confidence (2)

.github/copilot-instructions.md:11

  • [nitpick] This style rule may already be enforced via .editorconfig. If so, consider removing it here or referencing the specific rule in the config to avoid duplication.
* Insert a newline before the opening curly brace of any code block (e.g., after `if`, `for`, `while`, `foreach`, `using`, `try`, etc.).

.github/copilot-instructions.md:25

  • Verify that the project dependencies are already upgraded to xUnit v3; if not, update this line or adjust the test dependencies accordingly.
* We use xUnit SDK v3 for tests.

## General

* Make only high confidence suggestions when reviewing code changes.
* Always use the latest version C#, currently C# 13 features.
Copy link

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider rephrasing to "Always target the latest version of C# (currently 13 or later)" for clarity and grammatical accuracy.

Suggested change
* Always use the latest version C#, currently C# 13 features.
* Always target the latest version of C# (currently 13 or later).

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants