[FIX] Rebalancer-compatible Tolerance Rule #9467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
approved these changes
Apr 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR i've introduced the rebalancer-compatible tolerance rule. But there are two problems with it:
_pairwiseImbalanceis updated only upon silo status changes, and not during cluster imbalance changes. This means a cluster imbalance change would be reflected in the rule only after there was another silo status change. So it would lag-behind._pairwiseImbalance: While reads are naturally atomic on all platforms foruint, we can avoid stale-reads, and it is more natural to go "thread-safe" all the way.Microsoft Reviewers: Open in CodeFlow