Skip to content

Fix for CancelationToken cancel after finishing #9424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged

Fix for CancelationToken cancel after finishing #9424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Orleans.CodeGenerator/InvokableGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,8 @@ private MemberDeclarationSyntax GenerateGetCancellationTokenMethod(InvokableMeth
var cancellationTokenType = LibraryTypes.CancellationToken.ToTypeSyntax();
var cancellationTokenField = fields.First(f => SymbolEqualityComparer.Default.Equals(LibraryTypes.CancellationToken, f.FieldType));
var member = MethodDeclaration(cancellationTokenType, "GetCancellationToken")
.WithExpressionBody(ArrowExpressionClause(cancellationTokenField.FieldName.ToIdentifierName()))
.AddModifiers(Token(SyntaxKind.PublicKeyword), Token(SyntaxKind.OverrideKeyword))
.WithExpressionBody(ArrowExpressionClause(cancellationTokenField.FieldName.ToIdentifierName()))
.AddModifiers(Token(SyntaxKind.PublicKeyword), Token(SyntaxKind.OverrideKeyword))
.WithSemicolonToken(Token(SyntaxKind.SemicolonToken));
return member;
}
Expand All @@ -359,18 +359,21 @@ private MemberDeclarationSyntax GenerateTryCancelMethod(InvokableMethodDescripti
// C#:
// TryCancel()
// {
// _cts.Cancel(false);
// _cts?.Cancel(false);
// return true;
// }
var cancellationTokenField = fields.First(f => f is CancellationTokenSourceFieldDescription);
var member = MethodDeclaration(PredefinedType(Token(SyntaxKind.BoolKeyword)), "TryCancel")
.AddModifiers(Token(SyntaxKind.PublicKeyword), Token(SyntaxKind.OverrideKeyword))
.WithBody(Block(
ExpressionStatement(InvocationExpression(IdentifierName(cancellationTokenField.FieldName).Member("Cancel")).WithArgumentList(ArgumentList(SeparatedList([Argument(LiteralExpression(SyntaxKind.FalseLiteralExpression))])))),
ExpressionStatement(ConditionalAccessExpression(
IdentifierName(cancellationTokenField.FieldName),
InvocationExpression(MemberBindingExpression(IdentifierName("Cancel")))
.WithArgumentList(ArgumentList(SeparatedList([Argument(LiteralExpression(SyntaxKind.FalseLiteralExpression))]))))),
ReturnStatement(LiteralExpression(SyntaxKind.TrueLiteralExpression))));
return member;
}

private MemberDeclarationSyntax GenerateGetArgumentMethod(
InvokableMethodDescription methodDescription,
List<InvokerFieldDescription> fields)
Expand Down