Align behavior of grain storage providers when setting IGrainState<T> properties
#9417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix/storage-provider-behaviors
branch
3 times, most recently
from
de48ae9 to
7c8b987
Compare
ReubenBond
changed the title
IGrainState<T> properties
ReubenBond
force-pushed
the
fix/storage-provider-behaviors
branch
from
78b825f to
78df950
Compare
ReubenBond
added a commit
to ReubenBond/orleans
that referenced
this pull request
Apr 4, 2025
ReubenBond
force-pushed
the
fix/storage-provider-behaviors
branch
from
ded662b to
7d084bb
Compare
ReubenBond
added a commit
that referenced
this pull request
Apr 4, 2025
This was referenced Apr 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IGrainState<T>.Stateshould always be created usingActivator.CreateInstance<T>().IGrainState<T>.Stateshould never benullafter returning from anIGrainStoragemethod without an exception being thrown. That means it should be set to a new instance ofTinReadStateAsync()andClearStateAsync()before returning if it would otherwise have beennull.IGrainState<T>.RecordExistsshould betrueif the application has had the chance to initialize state since creation or the last time the state was reset. It should befalseif the state is not present in the database or the record has no contents, andtrueotherwise. The purpose is to give application developers a chance to initialize state to a valid value during activation and after clearing state.IGrainState<T>.ETagshould benullif storage system contains a record for the grain state, and non-nullotherwise.Fixes #7780
Fixes #9093
Fixes #3516
Fixes #9198
Microsoft Reviewers: Open in CodeFlow