[CodeGeneration] Pragma Restore CS1591 on the last namespace #9411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated code was only disabling CS1591 on the first, top-level namespace. Placing the restore on the last namespace should disable it for the whole "file"
ReubenBond
approved these changes
Mar 29, 2025
ReubenBond
approved these changes
Mar 30, 2025
This was referenced Mar 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated code was only disabling CS1591 on the first, top-level namespace. Placing the restore on the last namespace should disable it for the whole "file"
Fixes #9410
Microsoft Reviewers: Open in CodeFlow