Skip to content

Azure Table Storage: Use GetEntityIfExistsAsync to avoid exceptions for 404s #9373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Azure Table Storage: Use GetEntityIfExistsAsync to avoid exceptions for 404s #9373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/Azure/Shared/Storage/AzureTableDataManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
Expand Down Expand Up @@ -394,13 +394,17 @@ public async Task DeleteTableEntryAsync(T data, ETag eTag)
const string operation = "ReadSingleTableEntryAsync";
var startTime = DateTime.UtcNow;
if (Logger.IsEnabled(LogLevel.Trace)) Logger.LogTrace("{Operation} table {TableName} partitionKey {PartitionKey} rowKey {RowKey}", operation, TableName, partitionKey, rowKey);
T retrievedResult = default;

try
{
try
{
retrievedResult = await Table.GetEntityAsync<T>(partitionKey, rowKey);
var result = await Table.GetEntityIfExistsAsync<T>(partitionKey, rowKey);
if (result.HasValue)
{
//The ETag of data is needed in further operations.
return (result.Value, result.Value.ETag.ToString());
}
}
catch (RequestFailedException exception)
{
Expand All @@ -410,8 +414,6 @@ public async Task DeleteTableEntryAsync(T data, ETag eTag)
}
}

//The ETag of data is needed in further operations.
if (retrievedResult != null) return (retrievedResult, retrievedResult.ETag.ToString());
if (Logger.IsEnabled(LogLevel.Debug)) Logger.LogDebug("Could not find table entry for PartitionKey={PartitionKey} RowKey={RowKey}", partitionKey, rowKey);
return (default, default); // No data
}
Expand Down